Fix nightly release#42983
Merged
Merged
Conversation
Renaming the job in servo#42929 caused artifact_ids to be empty, which caused release failures. Signed-off-by: Jonathan Schwender <[email protected]>
This will make it easier to identify missing artifact IDs if the problem occurs again. Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
mukilan
approved these changes
Mar 3, 2026
| run: | | ||
| if [[ -z "${{ inputs.artifact_ids }}" ]]; then | ||
| echo "Error: No artifact IDs provided." | ||
| echo "Help: Check the calling workflow's inputs.artifact_ids parameter, usually created by a build workflow." |
Member
There was a problem hiding this comment.
Should this say calling workflow's output.artifact_ids as the value is set in the output in the caller?
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
jschwe
added a commit
to jschwe/servo
that referenced
this pull request
Mar 9, 2026
Renaming the openharmony build job in servo#42929 caused artifact_ids to be empty, which caused release failures. Additionally, we add a validation step to the upload workflow, to quickly pinpoint the issue of a missing input parameter, since apparently github won't throw an error if a required input parameter is empty. This should make it easier to pinpoint the issue if it happens again. Testing: Not tested. --------- Signed-off-by: Jonathan Schwender <[email protected]> (cherry picked from commit 27fb334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming the openharmony build job in #42929 caused artifact_ids to be empty, which caused release failures.
Additionally, we add a validation step to the upload workflow, to quickly pinpoint the issue of a missing input parameter,
since apparently github won't throw an error if a required input parameter is empty.
This should make it easier to pinpoint the issue if it happens again.
Testing: Not tested.