script: Refactors GPURenderBundle's drop implementation.#42982
Merged
yezhizhen merged 1 commit intoMar 3, 2026
Conversation
Moves the `Drop` logic for `GPURenderBundle` into a dedicated helper struct, `DroppableGPURenderBundle`. This change ensures that `GPURenderBundle` itself does not directly implement `Drop`, aligning with the policy to prevent direct `Drop` implementations on DOM types. Removes the `allowDropImpl` configuration for `GPURenderBundle` from script bindings. Signed-off-by: Domenico Rizzo <[email protected]>
servo-highfive
added
the
S-awaiting-review
sagudev
approved these changes
Mar 3, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
willypuzzle
deleted the
26488-Drop-impls-for-DOM-types-should-be-forbidden-GPURenderBundle
branch
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
Moves the `Drop` logic for `GPURenderBundle` into a dedicated helper struct, `DroppableGPURenderBundle`. This change ensures that `GPURenderBundle` itself does not directly implement `Drop`, aligning with the policy to prevent direct `Drop` implementations on DOM types. Removes the `allowDropImpl` configuration for `GPURenderBundle` from script bindings. Testing: WebGPU tests cover all related cases Fixes: Partially servo#26488 Signed-off-by: Domenico Rizzo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
Droplogic forGPURenderBundleinto a dedicated helper struct,DroppableGPURenderBundle. This change ensures thatGPURenderBundleitself does not directly implementDrop, aligning with the policy to prevent directDropimplementations on DOM types.Removes the
allowDropImplconfiguration forGPURenderBundlefrom script bindings.Testing: WebGPU tests cover all related cases
Fixes: Partially #26488