script: Add support for modulepreload link elements#42964
Conversation
|
🔨 Triggering try run (#22597613616) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22597613616): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (13)
|
|
|
|
🔨 Triggering try run (#22633003910) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22633003910): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (13)
|
|
|
This one always times out locally. |
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Specification says "A user agent must not delay the load event for this link type". When starting a modulepreload fetch the module owner will be `ModuleOwner::DynamicModule`, since a fetch with `ModuleOwner::Window` will be a blocking load. Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
…hat is already browsing-context connected Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
|
🔨 Triggering try run (#23160980573) for Linux (WPT) |
|
|
|
🔨 Triggering try run (#23162669526) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23162669526): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (1)
|
|
|
Signed-off-by: Gae24 <[email protected]>
Could this be a pref, so we can experiment with it? |
…43353) As suggested [here](#42964 (comment)), adds a preference to enable fetching modulepreload descendants, turned off by default. Testing: A successful build is enough. --------- Signed-off-by: Gae24 <[email protected]>
…ervo#43353) As suggested [here](servo#42964 (comment)), adds a preference to enable fetching modulepreload descendants, turned off by default. Testing: A successful build is enough. --------- Signed-off-by: Gae24 <[email protected]> Signed-off-by: Niya Gupta <[email protected]>
…ervo#43353) As suggested [here](servo#42964 (comment)), adds a preference to enable fetching modulepreload descendants, turned off by default. Testing: A successful build is enough. --------- Signed-off-by: Gae24 <[email protected]>
Add support to modulepreload link elements. Currently we only fetch the root module, as I think it is needs to be discussed whether we should always fetch module dependencies, or if it should be limited due to network constraints.
Inside
bind_to_treeI ended up callingfetch_and_process_modulepreloadinside a delayed task, since it would cause a crash due to DOM not being in a stable state when firing an event (queueing the event seems to also do the trick).Remaining tests failures are due to not supporting CSS modules and performance entries's
transfer_sizebeing 0.Testing: Covered by existing tests