fonts: Don't apply letter-spacing to formatting characters#42961
Merged
simonwuelker merged 3 commits intoMar 2, 2026
Conversation
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
servo-highfive
added
the
S-awaiting-review
simonwuelker
changed the title
letter-spacing to formatting charactersletter-spacing to formatting characters
mrobinson
approved these changes
Mar 2, 2026
Comment on lines
+110
to
+111
| icu_segmenter = "1.5.0" | ||
| icu_properties = "1.5.0" |
Member
There was a problem hiding this comment.
Alphabetical ordering nit:
Suggested change
| icu_segmenter = "1.5.0" | |
| icu_properties = "1.5.0" | |
| icu_properties = "1.5.0" | |
| icu_segmenter = "1.5.0" |
Comment on lines
+29
to
+30
| itertools = { workspace = true } | ||
| icu_properties = { workspace = true, features = ["compiled_data"] } |
Member
There was a problem hiding this comment.
Alphabetical ordering nit:
Suggested change
| itertools = { workspace = true } | |
| icu_properties = { workspace = true, features = ["compiled_data"] } | |
| icu_properties = { workspace = true, features = ["compiled_data"] } | |
| itertools = { workspace = true } |
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Simon Wülker <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
added a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
…2961) This change checks whether a character belongs to the `Cf` category of unicode characters before applying `letter-spacing`. The `fonts` crate now depends on `icu_properties`, but that crate is already in our dependency tree (with the same features enabled). Testing: New tests start to pass Fixes servo#38781 --------- Signed-off-by: Simon Wülker <[email protected]>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…2961) This change checks whether a character belongs to the `Cf` category of unicode characters before applying `letter-spacing`. The `fonts` crate now depends on `icu_properties`, but that crate is already in our dependency tree (with the same features enabled). Testing: New tests start to pass Fixes servo#38781 --------- Signed-off-by: Simon Wülker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change checks whether a character belongs to the
Cfcategory of unicode characters before applyingletter-spacing. Thefontscrate now depends onicu_properties, but that crate is already in our dependency tree (with the same features enabled).Testing: New tests start to pass
Fixes #38781