servoshell: Delete duplicate Info.plist#42955
Merged
Merged
Conversation
We had two `Info.plist` files. The maintained one is in the root directory of this repository. I don't see a reason why we need two plist files, so remove the unmaintained one. Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
mrobinson
reviewed
Mar 2, 2026
| #[unsafe(link_section = "__TEXT,__info_plist")] | ||
| #[unsafe(no_mangle)] | ||
| pub static INFO_PLIST: [u8; 619] = *include_bytes!("Info.plist"); | ||
| pub static INFO_PLIST: [u8; 924] = *include_bytes!("../../../../Info.plist"); |
Member
There was a problem hiding this comment.
I think I have a slight preference for storing the Info.plist in the servoshell subdirectory. If we ever ship another binary, I probably doesn't make sense to share a plist file.
Signed-off-by: Jonathan Schwender <[email protected]>
Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had two
Info.plistfiles. The maintained one is in the root directory of this repository.There is no reason for two plist files, so remove the unmaintained one.
Additionally, we also move the maintained version from the root directory to the servoshell directory.
Testing: We don't test the contents of the plist file.