Skip to content

ci: Remove dummy audio device related steps for linux-wpt#42945

Merged
yezhizhen merged 1 commit into
servo:mainfrom
yezhizhen:no-job
Mar 3, 2026
Merged

ci: Remove dummy audio device related steps for linux-wpt#42945
yezhizhen merged 1 commit into
servo:mainfrom
yezhizhen:no-job

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Mar 2, 2026

This doesn't seem to have any impact.

Try

Testing: This is a change to the testing CI configuration.

Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen requested a review from sagudev as a code owner March 2, 2026 02:46
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026
@sagudev sagudev requested review from mrobinson and removed request for sagudev March 2, 2026 05:50
@mrobinson mrobinson changed the title CI: Remove Dummy Audio related steps for linux-wpt ci: Remove Dummy Audio related steps for linux-wpt Mar 2, 2026
@mrobinson
Copy link
Copy Markdown
Member

Question: If there is an issue where examples failing is not failing the job, are we sure this isn't necessary to ultimately make the examples succeed?

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Mar 2, 2026

Question: If there is an issue where examples failing is not failing the job, are we sure this isn't necessary to ultimately make the examples succeed?

Not sure I understand the question. But there're two media related things:

This PR removes the second one, and should have nothing to do with Media Example.

@mrobinson
Copy link
Copy Markdown
Member

Have you tested this on both the GitHub and hosted runners?

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Mar 2, 2026

Seems we only run WPT on GitHub-hosted runners. So all samples collected are GitHub hosted.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026
@mrobinson mrobinson changed the title ci: Remove Dummy Audio related steps for linux-wpt ci: Remove dummy audio device related steps for linux-wpt Mar 2, 2026
@mrobinson
Copy link
Copy Markdown
Member

Okay. This is worth a shot.

@yezhizhen yezhizhen added this pull request to the merge queue Mar 3, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 3, 2026
@yezhizhen yezhizhen added this pull request to the merge queue Mar 3, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 3, 2026
Merged via the queue into servo:main with commit 76d8e34 Mar 3, 2026
42 checks passed
@yezhizhen yezhizhen deleted the no-job branch March 3, 2026 07:09
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 3, 2026
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants