script: Refactors GPUPipelineLayout to disallow direct Drop.#42937
Merged
sagudev merged 1 commit intoMar 2, 2026
Conversation
servo-highfive
added
the
S-awaiting-review
Moves the `Drop` implementation for `GPUPipelineLayout` to a dedicated private helper struct, `DroppableGPUPipelineLayout`. This ensures that DOM types do not directly implement `Drop`, aligning with best practices for resource management in the DOM. The associated `Bindings.conf` entry is removed as direct `Drop` is no longer needed for this type. Signed-off-by: Domenico Rizzo <[email protected]>
willypuzzle
force-pushed
the
26488-Drop-impls-for-DOM-types-should-be-forbidden-GPUPipelineLayout
branch
from
97ecb64 to
3996f2e
Compare
sagudev
approved these changes
Mar 2, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
willypuzzle
deleted the
26488-Drop-impls-for-DOM-types-should-be-forbidden-GPUPipelineLayout
branch
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
…2937) Moves the `Drop` implementation for `GPUPipelineLayout` to a dedicated private helper struct, `DroppableGPUPipelineLayout`. This ensures that DOM types do not directly implement `Drop`, aligning with best practices for resource management in the DOM. The associated `Bindings.conf` entry is removed as direct `Drop` is no longer needed for this type. Testing: WebGpu just coverages cases with proper tests Fixes: Partially servo#26488 Signed-off-by: Domenico Rizzo <[email protected]>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…2937) Moves the `Drop` implementation for `GPUPipelineLayout` to a dedicated private helper struct, `DroppableGPUPipelineLayout`. This ensures that DOM types do not directly implement `Drop`, aligning with best practices for resource management in the DOM. The associated `Bindings.conf` entry is removed as direct `Drop` is no longer needed for this type. Testing: WebGpu just coverages cases with proper tests Fixes: Partially servo#26488 Signed-off-by: Domenico Rizzo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
Dropimplementation forGPUPipelineLayoutto a dedicated private helper struct,DroppableGPUPipelineLayout. This ensures that DOM types do not directly implementDrop, aligning with best practices for resource management in the DOM. The associatedBindings.confentry is removed as directDropis no longer needed for this type.Testing: WebGpu just coverages cases with proper tests
Fixes: Partially #26488