script: Mark disabled elements pointed at and elements targets of touch events as :active#42935
Merged
Merged
Conversation
Signed-off-by: webbeef <[email protected]>
servo-highfive
added
the
S-awaiting-review
Signed-off-by: webbeef <[email protected]>
mrobinson
reviewed
Mar 1, 2026
mrobinson
reviewed
Mar 1, 2026
| [Clicking on a child of a disabled button should make the button match the :active selector.] | ||
| expected: FAIL | ||
|
|
||
| [Clicking on a disabled input should make it match the :active selector.] |
Member
There was a problem hiding this comment.
Any idea why this is still failing?
Contributor
Author
There was a problem hiding this comment.
We still fail the one because the hit test ends up in a <div> of the <input> shadow DOM.
mrobinson
changed the title
:active
mrobinson
changed the title
:active:active
Signed-off-by: webbeef <[email protected]>
webbeef
force-pushed
the
pointed-element-active
branch
from
91954a8 to
4730def
Compare
mrobinson
approved these changes
Mar 2, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
…ch events as `:active` (servo#42935) This implements the "If the element is [being actively pointed at](https://html.spec.whatwg.org/multipage/semantics-other.html#being-actively-pointed-at)" part of https://html.spec.whatwg.org/multipage/semantics-other.html#selector-active Also added support for activation of controls tied to a `<label for=...>` element as this is part of the same `/html/semantics/selectors/pseudo-classes/active-disabled.html` WPT test. We still fail the `<input disabled>` one because the hit test ends up in a `<div>` of the input shadow DOM. Testing: New WPT tests are passing Fixes: Partial fix for servo#7333 and servo#20284 (I think we still lack support for the focusable elements). --------- Signed-off-by: webbeef <[email protected]>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…ch events as `:active` (servo#42935) This implements the "If the element is [being actively pointed at](https://html.spec.whatwg.org/multipage/semantics-other.html#being-actively-pointed-at)" part of https://html.spec.whatwg.org/multipage/semantics-other.html#selector-active Also added support for activation of controls tied to a `<label for=...>` element as this is part of the same `/html/semantics/selectors/pseudo-classes/active-disabled.html` WPT test. We still fail the `<input disabled>` one because the hit test ends up in a `<div>` of the input shadow DOM. Testing: New WPT tests are passing Fixes: Partial fix for servo#7333 and servo#20284 (I think we still lack support for the focusable elements). --------- Signed-off-by: webbeef <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the "If the element is being actively pointed at" part of https://html.spec.whatwg.org/multipage/semantics-other.html#selector-active
Also added support for activation of controls tied to a
<label for=...>element as this is part of the same/html/semantics/selectors/pseudo-classes/active-disabled.htmlWPT test. We still fail the<input disabled>one because the hit test ends up in a<div>of the input shadow DOM.Testing: New WPT tests are passing
Fixes: Partial fix for #7333 and #20284 (I think we still lack support for the focusable elements).