ohos CI: Add timeouts#42929
Merged
Merged
Conversation
sagudev
approved these changes
Mar 1, 2026
jschwe
approved these changes
Mar 1, 2026
yezhizhen
commented
Mar 1, 2026
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
jschwe
added a commit
to jschwe/servo
that referenced
this pull request
Mar 3, 2026
Renaming the job in servo#42929 caused artifact_ids to be empty, which caused release failures. Signed-off-by: Jonathan Schwender <[email protected]>
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Renaming the openharmony build job in #42929 caused artifact_ids to be empty, which caused release failures. Additionally, we add a validation step to the upload workflow, to quickly pinpoint the issue of a missing input parameter, since apparently github won't throw an error if a required input parameter is empty. This should make it easier to pinpoint the issue if it happens again. Testing: Not tested. --------- Signed-off-by: Jonathan Schwender <[email protected]>
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
There's some hanged scenarios with mitmproxy: https://github.com/servo/servo/actions/runs/22539387007/job/65292396178 1. We rename `build` to `build-openharmony`. 2. We add - 60 minutes timeout for each Build profile - 40 minutes for bencher (Normally finish under 10 mins) - 20 mins for scenario tests. (Normally finish under 4 mins) --------- Signed-off-by: Euclid Ye <[email protected]>
jschwe
added a commit
to jschwe/servo
that referenced
this pull request
Mar 3, 2026
Renaming the job in servo#42929 silently broke the evaluation here. Signed-off-by: Jonathan Schwender <[email protected]>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Renaming the job in #42929 silently broke the evaluation here. Testing: Can only be tested on main / in priviledge contexts / otherwise the unsigned binary is anyway built. Fixes: ohos bencher failing on main (since the wrong binary name is chosen) Signed-off-by: Jonathan Schwender <[email protected]>
jschwe
added a commit
to jschwe/servo
that referenced
this pull request
Mar 9, 2026
Renaming the openharmony build job in servo#42929 caused artifact_ids to be empty, which caused release failures. Additionally, we add a validation step to the upload workflow, to quickly pinpoint the issue of a missing input parameter, since apparently github won't throw an error if a required input parameter is empty. This should make it easier to pinpoint the issue if it happens again. Testing: Not tested. --------- Signed-off-by: Jonathan Schwender <[email protected]> (cherry picked from commit 27fb334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's some hanged scenarios with mitmproxy: https://github.com/servo/servo/actions/runs/22539387007/job/65292396178
buildtobuild-openharmony.