Skip to content

ohos CI: Add timeouts#42929

Merged
yezhizhen merged 2 commits into
servo:mainfrom
yezhizhen:ci-stuck
Mar 1, 2026
Merged

ohos CI: Add timeouts#42929
yezhizhen merged 2 commits into
servo:mainfrom
yezhizhen:ci-stuck

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Mar 1, 2026

There's some hanged scenarios with mitmproxy: https://github.com/servo/servo/actions/runs/22539387007/job/65292396178

  1. We rename build to build-openharmony.
  2. We add
  • 60 minutes timeout for each Build profile
  • 40 minutes for bencher (Normally finish under 10 mins)
  • 20 mins for scenario tests. (Normally finish under 4 mins)

@yezhizhen yezhizhen requested a review from jschwe March 1, 2026 09:57
@yezhizhen yezhizhen requested a review from sagudev as a code owner March 1, 2026 09:57
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 1, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 1, 2026
Comment thread .github/workflows/ohos.yml Outdated
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 1, 2026
@yezhizhen yezhizhen enabled auto-merge March 1, 2026 10:40
Comment thread .github/workflows/ohos.yml Outdated
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen disabled auto-merge March 1, 2026 10:58
@yezhizhen yezhizhen enabled auto-merge March 1, 2026 10:58
@yezhizhen yezhizhen added this pull request to the merge queue Mar 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 1, 2026
Merged via the queue into servo:main with commit 95af091 Mar 1, 2026
30 checks passed
@yezhizhen yezhizhen deleted the ci-stuck branch March 1, 2026 11:53
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 1, 2026
jschwe added a commit to jschwe/servo that referenced this pull request Mar 3, 2026
Renaming the job in servo#42929 caused artifact_ids to be empty, which caused
release failures.

Signed-off-by: Jonathan Schwender <[email protected]>
@jschwe jschwe mentioned this pull request Mar 3, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Mar 3, 2026
Renaming the openharmony build job in #42929 caused artifact_ids to be
empty, which caused release failures.
Additionally, we add a validation step to the upload workflow, to
quickly pinpoint the issue of a missing input parameter,
since apparently github won't throw an error if a required input
parameter is empty.
This should make it easier to pinpoint the issue if it happens again. 

Testing: Not tested.

---------

Signed-off-by: Jonathan Schwender <[email protected]>
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
There's some hanged scenarios with mitmproxy:
https://github.com/servo/servo/actions/runs/22539387007/job/65292396178

1. We rename `build` to `build-openharmony`.
2. We add 
- 60 minutes timeout for each Build profile
- 40 minutes for bencher (Normally finish under 10 mins)
- 20 mins for scenario tests. (Normally finish under 4 mins)

---------

Signed-off-by: Euclid Ye <[email protected]>
jschwe added a commit to jschwe/servo that referenced this pull request Mar 3, 2026
Renaming the job in servo#42929 silently broke the evaluation here.

Signed-off-by: Jonathan Schwender <[email protected]>
github-merge-queue Bot pushed a commit that referenced this pull request Mar 3, 2026
Renaming the job in #42929 silently broke the evaluation here.

Testing: Can only be tested on main / in priviledge contexts / otherwise
the unsigned binary is anyway built.
Fixes: ohos bencher failing on main (since the wrong binary name is
chosen)

Signed-off-by: Jonathan Schwender <[email protected]>
jschwe added a commit to jschwe/servo that referenced this pull request Mar 9, 2026
Renaming the openharmony build job in servo#42929 caused artifact_ids to be
empty, which caused release failures.
Additionally, we add a validation step to the upload workflow, to
quickly pinpoint the issue of a missing input parameter,
since apparently github won't throw an error if a required input
parameter is empty.
This should make it easier to pinpoint the issue if it happens again.

Testing: Not tested.

---------

Signed-off-by: Jonathan Schwender <[email protected]>
(cherry picked from commit 27fb334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants