Skip to content

script: Reorder reading algorithm and data arguments in WebCrypto#42927

Merged
yezhizhen merged 1 commit intoservo:mainfrom
kkoyung:reorder-algorithm-data
Mar 1, 2026
Merged

script: Reorder reading algorithm and data arguments in WebCrypto#42927
yezhizhen merged 1 commit intoservo:mainfrom
kkoyung:reorder-algorithm-data

Conversation

@kkoyung
Copy link
Copy Markdown
Member

@kkoyung kkoyung commented Mar 1, 2026

The specification of WebCrypto and Modern Algorithms in WebCrypto has updated to reorder reading algorithm and data arguments in "encrypt", "decrypt", "sign", "verify", "digest", "importKey", "unwrapKey", "decapsulateKey" and "decapsulateBits" methods. This patch updates our implementation accordingly.

The relevant commits in specification repositories:

Testing: Pass new WPT tests added in web-platform-tests/wpt#57614 and #42925

The specification of WebCrypto and Modern Algorithms in WebCrypto has
updated to reorder reading algorithm and data arguments in "encrypt",
"decrypt", "sign", "verify", "digest", "importKey", "unwrapKey",
"decapsulateKey" and "decapsulateBits" methods.

WebCrypto:
w3c/webcrypto@5b57233

Modern Algorithms in WebCrypto:
WICG/webcrypto-modern-algos@ae72ee6

This patch updates our implementation accordingly.

Testing: Pass new WPT tests added in
web-platform-tests/wpt#57614 and
servo#42925

Signed-off-by: Kingsley Yung <[email protected]>
@kkoyung kkoyung requested a review from gterzian as a code owner March 1, 2026 04:10
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 1, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 1, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Mar 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 1, 2026
@yezhizhen
Copy link
Copy Markdown
Member

https://github.com/servo/servo/actions/runs/22539387007/job/65292396178#logs
This is stuck. I manually cancelled the workflow.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 1, 2026
@yezhizhen yezhizhen added this pull request to the merge queue Mar 1, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 1, 2026
Merged via the queue into servo:main with commit 0eeb44c Mar 1, 2026
39 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 1, 2026
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
…rvo#42927)

The specification of WebCrypto and Modern Algorithms in WebCrypto has
updated to reorder reading algorithm and data arguments in "encrypt",
"decrypt", "sign", "verify", "digest", "importKey", "unwrapKey",
"decapsulateKey" and "decapsulateBits" methods. This patch updates our
implementation accordingly.

The relevant commits in specification repositories:
- WebCrypto:
w3c/webcrypto@5b57233
- Modern Algorithms in WebCrypto:
WICG/webcrypto-modern-algos@ae72ee6

Testing: Pass new WPT tests added in
web-platform-tests/wpt#57614 and
servo#42925

Signed-off-by: Kingsley Yung <[email protected]>
@kkoyung kkoyung deleted the reorder-algorithm-data branch March 7, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants