Skip to content

devtools: Implement initial support for Step in, Step out and Step over#42907

Merged
atbrakhi merged 1 commit into
servo:mainfrom
eerii:debugger_step
Mar 2, 2026
Merged

devtools: Implement initial support for Step in, Step out and Step over#42907
atbrakhi merged 1 commit into
servo:mainfrom
eerii:debugger_step

Conversation

@eerii
Copy link
Copy Markdown
Member

@eerii eerii commented Feb 27, 2026

We are adding initial support for stepping in the debugger. Step over mostly works, but Step in and Step out have some quirks that we are working on.

2026-02-27 12-32-05

Testing: DevTools tests and manual checks.
Part of: #36027

@eerii eerii force-pushed the debugger_step branch 2 times, most recently from d484041 to c3e2746 Compare March 2, 2026 09:29
@eerii
Copy link
Copy Markdown
Member Author

eerii commented Mar 2, 2026

Upcoming work: Fix how the frames message is handled by the thread actor. This causes some issues when moving between functions that sometimes makes stepping unreliable.

@eerii eerii marked this pull request as ready for review March 2, 2026 10:03
@eerii eerii requested a review from gterzian as a code owner March 2, 2026 10:03
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026
@eerii eerii requested a review from atbrakhi March 2, 2026 10:03
@atbrakhi atbrakhi added this pull request to the merge queue Mar 2, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 2, 2026
Merged via the queue into servo:main with commit 88f2469 Mar 2, 2026
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2026
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
…ep over` (servo#42907)

We are adding initial support for stepping in the debugger. Step over
mostly works, but Step in and Step out have some quirks that we are
working on.

![2026-02-27
12-32-05](https://github.com/user-attachments/assets/0b73b32c-efa3-444c-80a4-f863a64b6fdc)

Testing: DevTools tests and manual checks.
Part of: servo#36027

Signed-off-by: eri <[email protected]>
Co-authored-by: atbrakhi <[email protected]>
@eerii eerii mentioned this pull request Mar 4, 2026
@eerii eerii deleted the debugger_step branch May 20, 2026 18:33
offline-ant pushed a commit to offline-ant/havi that referenced this pull request Jun 4, 2026
…ep over` (servo#42907)

We are adding initial support for stepping in the debugger. Step over
mostly works, but Step in and Step out have some quirks that we are
working on.

![2026-02-27
12-32-05](https://github.com/user-attachments/assets/0b73b32c-efa3-444c-80a4-f863a64b6fdc)

Testing: DevTools tests and manual checks.
Part of: servo#36027

Signed-off-by: eri <[email protected]>
Co-authored-by: atbrakhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants