Skip to content

script: Replace RAII AutoIncumbentScript with function wrapper#42905

Merged
sagudev merged 2 commits intoservo:mainfrom
sagudev:wrapper-ais
Feb 28, 2026
Merged

script: Replace RAII AutoIncumbentScript with function wrapper#42905
sagudev merged 2 commits intoservo:mainfrom
sagudev:wrapper-ais

Conversation

@sagudev
Copy link
Copy Markdown
Member

@sagudev sagudev commented Feb 27, 2026

As in #42715 we will need cx in drop so we need to go to function wrapper pattern.

Testing: Just refactor should be covered by WPT tests.

@sagudev sagudev requested a review from jdm February 27, 2026 10:50
@sagudev sagudev requested a review from gterzian as a code owner February 27, 2026 10:50
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 27, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 28, 2026
Signed-off-by: sagudev <[email protected]>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 28, 2026
@sagudev sagudev enabled auto-merge February 28, 2026 06:45
@sagudev sagudev added this pull request to the merge queue Feb 28, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 28, 2026
Merged via the queue into servo:main with commit 8757ccb Feb 28, 2026
33 checks passed
@sagudev sagudev deleted the wrapper-ais branch February 28, 2026 07:32
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 28, 2026
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
…#42905)

As in servo#42715 we will need cx in drop
so we need to go to function wrapper pattern.

Testing: Just refactor should be covered by WPT tests.

---------

Signed-off-by: sagudev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants