Pass Request's URL for `LargestContentfulPaint` Entry by shubhamg13 · Pull Request #42901 · servo/servo

shubhamg13 · 2026-02-27T09:18:40Z

Pass Request URL to LargestContnetfulPaint Entry

Testing: WPT Expectations Updated.
Fixes: #42902

servo-wpt-sync · 2026-02-27T09:35:48Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#58100) with upstreamable changes.

servo-wpt-sync · 2026-02-27T09:38:46Z

🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#58100).

github-actions · 2026-02-28T08:11:51Z

🔨 Triggering try run (#22516877694) for Linux (WPT)

github-actions · 2026-02-28T08:50:54Z

Test results for linux-wpt from try job (#22516877694):

Flaky unexpected result (35)

OK [expected TIMEOUT] /IndexedDB/idbfactory_open.any.worker.html
- PASS [expected FAIL] subtest: Calling open() with version argument 1.5 should not throw.
- PASS [expected TIMEOUT] subtest: Calling open() with version argument 9007199254740991 should not throw.
- PASS [expected TIMEOUT] subtest: Calling open() with version argument undefined should not throw.

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 10 more unexpected results...
CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
FAIL [expected PASS] /css/css-ui/appearance-button-001.html
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK [expected ERROR] /fetch/fetch-later/quota/cross-origin-iframe/multiple-iframes.https.window.html
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```
ERROR [expected OK] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

CRASH [expected OK] /html/browsers/browsing-the-web/unloading-documents/unload/002.html
CRASH [expected OK] /html/canvas/element/compositing/2d.composite.transparent.destination-out.html
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
- PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- FAIL [expected PASS] subtest: Cross-Origin video should get upgraded even if CORS is set
```
assert_equals: Length. Other host expected 1 but got Infinity
```
OK /preload/link-header-preload-delay-onload.html (#39622)
- FAIL [expected PASS] subtest: Makes sure that Link headers preload resources and block window.onload after resource discovery
```
assert_true: expected true got false
```
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
PASS [expected TIMEOUT] /visual-viewport/viewport-apply-initial-scale-after-navigation.html (#41582)

OK /webdriver/tests/classic/back/user_prompts.py

FAIL [expected PASS] subtest: test_accept[alert]

AssertionError: assert 'about:blank' == 'https://web-platform.test:8443/webdriver/tests/support/inline.py?doc=%3C%21doctype+html%3E%0A%3Cmeta+charset%3DUTF-8%3E%0A%3Cp+id%3D1%3E&amp;mime=text%2Fhtml&amp;charset=UTF-8'

OK /webdriver/tests/classic/get_active_element/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/get_current_url/file.py
- FAIL [expected PASS] subtest: test_get_current_url_file_protocol
```
AssertionError: no such window (404)
```
OK /webdriver/tests/classic/get_named_cookie/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/take_screenshot/iframe.py
- ERROR [expected PASS] subtest: test_always_captures_top_browsing_context
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_source_origin[same_origin]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_source_origin[cross_origin]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK /webxr/xrSession_features_deviceSupport.https.html (#24357)
- FAIL [expected PASS] subtest: Immersive XRSession requests with no supported device should reject
```
assert_unreached: Should have rejected: undefined Reached unreachable code
```

Stable unexpected results that are known to be intermittent (20)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/transaction-scheduling-mixed-scopes.any.html (#42753)
- PASS [expected FAIL] subtest: Check that scope restrictions on mixed transactions are enforced.
FAIL [expected PASS] /_mozilla/css/img_size_a.html (#42908)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
ERROR [expected CRASH] /_webgl/conformance2/misc/uninitialized-test-2.html (#41656)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
assert_equals: expected "DIV" but got "BODY"
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)
- PASS [expected FAIL] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```

github-actions · 2026-02-28T08:51:01Z

✨ Try run (#22516877694) succeeded.

servo-wpt-sync · 2026-02-28T15:25:07Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#58145) with upstreamable changes.

shubhamg13 · 2026-02-28T15:26:20Z

Requesting for a very early review thoughts. (Adding more reviewers since this change range over several files)

And let me know if needs to be split in several PRs and How.

servo-wpt-sync · 2026-02-28T15:26:25Z

🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#58145).

TimvdLippe

Some nits about structure and flow of arguments, but generally the approach looks fine to me.

shubhamg13 · 2026-03-02T13:40:39Z

Some nits about structure and flow of arguments, but generally the approach looks fine to me.

If it is good to go. Please skip #42949.

Signed-off-by: Shubham Gupta <[email protected]>

Pass Request URL to `LargestContnetfulPaint` Entry Testing: WPT Expectations Updated. Fixes: servo#42902 --------- Signed-off-by: Shubham Gupta <[email protected]>

shubhamg13 requested review from Loirooriol, gterzian and mrobinson as code owners February 27, 2026 09:18

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 27, 2026

shubhamg13 marked this pull request as draft February 27, 2026 09:18

servo-wpt-sync mentioned this pull request Feb 27, 2026

Pass Request URL for Largest Contentful Paint Entry web-platform-tests/wpt#58100

Closed

shubhamg13 force-pushed the add_utl_to_image_fragment branch from 751ff07 to c9cb8b8 Compare February 27, 2026 09:37

shubhamg13 mentioned this pull request Feb 27, 2026

Feature: LargestContentfulPaint #42000

Open

shubhamg13 added the T-linux-wpt Do a try run of the WPT label Feb 28, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Feb 28, 2026

shubhamg13 force-pushed the add_utl_to_image_fragment branch 2 times, most recently from a41ba93 to b427153 Compare February 28, 2026 15:23

shubhamg13 marked this pull request as ready for review February 28, 2026 15:24

servo-wpt-sync mentioned this pull request Feb 28, 2026

Pass Request URL for Largest Contentful Paint Entry web-platform-tests/wpt#58145

Closed

shubhamg13 requested review from TimvdLippe and jdm February 28, 2026 15:25

shubhamg13 force-pushed the add_utl_to_image_fragment branch from b427153 to 94fbffe Compare February 28, 2026 15:37

TimvdLippe reviewed Feb 28, 2026

View reviewed changes

Comment thread components/script/dom/performance/largestcontentfulpaint.rs

Comment thread components/layout/dom.rs Outdated

Comment thread components/script/dom/performance/largestcontentfulpaint.rs Outdated

shubhamg13 force-pushed the add_utl_to_image_fragment branch from 94fbffe to 6bbffcc Compare March 2, 2026 09:03

servo-highfive added the S-needs-rebase There are merge conflict errors. label Mar 2, 2026

shubhamg13 force-pushed the add_utl_to_image_fragment branch from 6bbffcc to 1b1416b Compare March 2, 2026 13:32

servo-highfive removed the S-needs-rebase There are merge conflict errors. label Mar 2, 2026

shubhamg13 requested a review from TimvdLippe March 2, 2026 13:34

shubhamg13 force-pushed the add_utl_to_image_fragment branch from 1b1416b to abcaf67 Compare March 2, 2026 13:49

TimvdLippe approved these changes Mar 2, 2026

View reviewed changes

Comment thread components/script/dom/performance/largestcontentfulpaint.rs Outdated

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026

shubhamg13 force-pushed the add_utl_to_image_fragment branch from abcaf67 to ad1b9ba Compare March 2, 2026 16:45

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026

shubhamg13 requested a review from TimvdLippe March 2, 2026 16:45

shubhamg13 added 2 commits March 3, 2026 01:42

Pass Request URL for Largest Contentful Paint Entry

b271360

Signed-off-by: Shubham Gupta <[email protected]>

Update WPT tests Expectations

5d133da

Signed-off-by: Shubham Gupta <[email protected]>

shubhamg13 force-pushed the add_utl_to_image_fragment branch from ad1b9ba to 5d133da Compare March 2, 2026 17:42

shubhamg13 changed the title ~~Pass Request URL for Largest Contentful Paint Entry~~ Pass Request's URL for LargestContentfulPaint Entry Mar 2, 2026

TimvdLippe added this pull request to the merge queue Mar 2, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2026

Merged via the queue into servo:main with commit 77e4bfb Mar 2, 2026
31 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2026

shubhamg13 deleted the add_utl_to_image_fragment branch March 3, 2026 00:39

Uh oh!

Conversation

shubhamg13 commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 27, 2026

Uh oh!

servo-wpt-sync commented Feb 27, 2026

Uh oh!

github-actions Bot commented Feb 28, 2026

Uh oh!

github-actions Bot commented Feb 28, 2026

Uh oh!

github-actions Bot commented Feb 28, 2026

Uh oh!

servo-wpt-sync commented Feb 28, 2026

Uh oh!

shubhamg13 commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 28, 2026

Uh oh!

TimvdLippe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shubhamg13 commented Mar 2, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shubhamg13 commented Feb 27, 2026 •

edited

Loading

shubhamg13 commented Feb 28, 2026 •

edited

Loading