script bindings: Fix warning about unused span.#42850
Merged
sagudev merged 1 commit intoservo:mainfrom Feb 25, 2026
Merged
Conversation
The span needs to be assigned to a variable, so that it drops at the end of scope. Additionally also switch tho the profile_traits macro to simplify the statement. Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
jschwe
commented
Feb 25, 2026
| pub fn run_a_script<D: DomTypes, R>(global: &D::GlobalScope, f: impl FnOnce() -> R) -> R { | ||
| let settings_stack = <D as DomHelpers<D>>::settings_stack(); | ||
| settings_stack.with(|stack| { | ||
| let _span = settings_stack.with(|stack| { |
Member
Author
There was a problem hiding this comment.
It's debatable if we should drop / end the span after line 44, or if it makes sense to include the cleanup. No strong opinion.
mrobinson
approved these changes
Feb 25, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
shubhamg13
pushed a commit
to shubhamg13/servo
that referenced
this pull request
Mar 2, 2026
The span needs to be assigned to a variable, so that it drops at the end of scope. This was introduced in servo#42715. Additionally also switch tho the profile_traits macro to simplify the statement. Testing: Manually verified the warning is fixed. Signed-off-by: Jonathan Schwender <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The span needs to be assigned to a variable, so that it drops at the end of scope.
This was introduced in #42715.
Additionally also switch tho the profile_traits macro to simplify the statement.
Testing: Manually verified the warning is fixed.