devtools: Register frame actor before pause#42844
Merged
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
We need a map between frame actor ids (from devtools) and frame objects (from debugger.js) to implement stepping hooks in the future. To achieve this, we register the frame actor with a call to the devtools before entering the event loop when the debugger is paused. Instead of creating the frame actor in `handle_debugger_pause`, we create it before. Signed-off-by: eri <[email protected]> Co-authored-by: atbrakhi <[email protected]>
eerii
force-pushed
the
register-frame-actor
branch
from
1a624a8 to
95dbc15
Compare
atbrakhi
approved these changes
Feb 26, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
shubhamg13
pushed a commit
to shubhamg13/servo
that referenced
this pull request
Mar 2, 2026
We need a map between frame actor ids (from devtools) and frame objects (from debugger.js) to implement stepping hooks in the future. To achieve this, we register the frame actor with a call to the devtools before entering the event loop when the debugger is paused. Instead of creating the frame actor in `handle_debugger_pause`, we create it before. Testing: It passes existing devtools tests Part of: servo#36027 Signed-off-by: eri <[email protected]> Co-authored-by: atbrakhi <[email protected]>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
We need a map between frame actor ids (from devtools) and frame objects (from debugger.js) to implement stepping hooks in the future. To achieve this, we register the frame actor with a call to the devtools before entering the event loop when the debugger is paused. Instead of creating the frame actor in `handle_debugger_pause`, we create it before. Testing: It passes existing devtools tests Part of: servo#36027 Signed-off-by: eri <[email protected]> Co-authored-by: atbrakhi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a map between frame actor ids (from devtools) and frame objects (from debugger.js) to implement stepping hooks in the future.
To achieve this, we register the frame actor with a call to the devtools before entering the event loop when the debugger is paused. Instead of creating the frame actor in
handle_debugger_pause, we create it before.Testing: It passes existing devtools tests
Part of: #36027