layout: Reuse boxes for independent formatting contexts with self damage if compatible#42783
Merged
Loirooriol merged 1 commit intoservo:mainfrom Feb 24, 2026
Merged
Conversation
|
🔨 Triggering try run (#22312735945) for Linux (WPT) |
b09d0bf to
9ccfc48
Compare
|
Test results for linux-wpt from try job (#22312735945): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (6)
|
|
|
9ccfc48 to
5a64fb2
Compare
|
🔨 Triggering try run (#22348682455) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22348682455): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (21)
|
|
✨ Try run (#22348682455) succeeded. |
Previously, when a formatting context root had rebuild damage from its own (not from ancestors), we weren't reusing it. Now we check if the level of the box (i.e. whether it's inline-level, block-level, a table cell, a table caption, or absolutely positioned) that will be generated by the new style is compatible with the old box. And if so, we reuse it. Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>
5a64fb2 to
fe10a3d
Compare
mrobinson
approved these changes
Feb 24, 2026
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Feb 25, 2026
This fixes an oversight from servo#42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children. Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Feb 26, 2026
This fixes an oversight from servo#42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children. Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Feb 26, 2026
This fixes an oversight from servo#42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children. Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
This fixes an oversight from #42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children. This exposed some problems in `rebuild_box_tree_from_independent_formatting_context()`: 1. When reusing a block-level box that established an independent formatting context, we weren't checking that the new style was still block-level. 2. When reusing a block-level abspos box, we weren't checking if the new original display was inline-level, preventing it from being handled as a block-level because of the static position. 3. When reusing a flex item, we weren't checking if the `order` had changed. Testing: we have test coverage for the 3 problems above: 1. Covered by `/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display.html`, and also adding a new `/css/css-display/display-flow-root-dynamic.html`. 2. Covered by `/css/CSS2/abspos/hypothetical-box-dynamic.html` 3. Covered by `/css/css-display/order-dynamic.html`. Signed-off-by: Oriol Brufau <[email protected]> Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]>
shubhamg13
pushed a commit
to shubhamg13/servo
that referenced
this pull request
Mar 2, 2026
…#42847) This fixes an oversight from servo#42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children. This exposed some problems in `rebuild_box_tree_from_independent_formatting_context()`: 1. When reusing a block-level box that established an independent formatting context, we weren't checking that the new style was still block-level. 2. When reusing a block-level abspos box, we weren't checking if the new original display was inline-level, preventing it from being handled as a block-level because of the static position. 3. When reusing a flex item, we weren't checking if the `order` had changed. Testing: we have test coverage for the 3 problems above: 1. Covered by `/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display.html`, and also adding a new `/css/css-display/display-flow-root-dynamic.html`. 2. Covered by `/css/CSS2/abspos/hypothetical-box-dynamic.html` 3. Covered by `/css/css-display/order-dynamic.html`. Signed-off-by: Oriol Brufau <[email protected]> Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a formatting context root had rebuild damage from its own (not from ancestors), we weren't reusing it. Now we check if the level of the box (i.e. whether it's inline-level, block-level, a table cell, a table caption, or absolutely positioned) that will be generated by the new style is compatible with the old box. And if so, we reuse it.
Testing: Not needed, there should be no behavior change