layout: Create a webrender stacking context for fragments with transform-style: preserve-3d#42755
Merged
simonwuelker merged 3 commits intoservo:mainfrom Feb 22, 2026
Merged
Conversation
…orm-style: preserve-3d" Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#22285918394) for Linux (WPT) |
Loirooriol
approved these changes
Feb 22, 2026
| !style.has_effective_transform_or_perspective(FragmentFlags::empty()) && | ||
| style.clone_clip_path() == ClipPath::None | ||
| style.clone_clip_path() == ClipPath::None && | ||
| style.get_used_transform_style() == TransformStyle::Flat |
Contributor
There was a problem hiding this comment.
get_used_transform_style() is also used below, so store it in a variable.
And no need to address it here, but it uses overrides_transform_style() which doesn't take isolation into account. They should probably be moved into Servo anyways since Gecko is not using this logic at all.
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Simon Wülker <[email protected]>
servo-highfive
added
the
S-awaiting-review
|
Test results for linux-wpt from try job (#22285918394): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (22)
|
|
✨ Try run (#22285918394) succeeded. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
added a commit
to simonwuelker/servo
that referenced
this pull request
Feb 23, 2026
…form-style: preserve-3d` (servo#42755) Such elements already establish stacking contexts, but we don't tell webrender about them. Two new failures appear, which I believe incorrectly passed before. We fail because we don't support the concept of a [3D rendering context](https://drafts.csswg.org/css-transforms-2/#3d-rendering-context). If I understand correctly then we act as if a 3D rendering context was the same as a stacking context, but elements in the same stacking context may use different 3D coordinate systems, see https://github.com/web-platform-tests/wpt/blob/1903a5a80470223d7117b91b3e4cda3d7c037f40/css/css-transforms/transform3d-sorting-004.html#L9-L14 for example. Fixes servo#30474 Testing: New tests start to pass. --------- Signed-off-by: Simon Wülker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such elements already establish stacking contexts, but we don't tell webrender about them.
Two new failures appear, which I believe incorrectly passed before. We fail because we don't support the concept of a 3D rendering context.
If I understand correctly then we act as if a 3D rendering context was the same as a stacking context, but elements in the same stacking context may use different 3D coordinate systems, see https://github.com/web-platform-tests/wpt/blob/1903a5a80470223d7117b91b3e4cda3d7c037f40/css/css-transforms/transform3d-sorting-004.html#L9-L14 for example.
Fixes #30474
Testing: New tests start to pass.