script: Pass &mut JSContext to more dom methods#42751
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Feb 22, 2026
Merged
Conversation
split from servo#42635 Signed-off-by: sagudev <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 22, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Thanks for splitting them off! This was a lot more straightforward me to review.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Feb 23, 2026
split from servo#42635, some dom methods are also called from other function, which require passing down cx from many more places :( Testing: Just refactor, but should be covered by WPT. Part of servo#42638 Signed-off-by: sagudev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split from #42635, some dom methods are also called from other function, which require passing down cx from many more places :(
Testing: Just refactor, but should be covered by WPT.
Part of #42638