script: pointer events: pointerenter, pointerout, pointerleave, pointerover#42736
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Member
|
I'm reviewing this and will finalize it tomorrow. |
yezhizhen
reviewed
Feb 23, 2026
Member
yezhizhen
left a comment
yezhizhen
left a comment
There was a problem hiding this comment.
Will do another round for doucument_event_handler.rs.
| let pressure = if event_type == "pointerup" || event_type == "pointercancel" { | ||
| // Pressure is 0.5 for active touches, 0.0 for up/cancel/out/leave | ||
| let pressure = if event_type == "pointerup" || | ||
| event_type == "pointercancel" || |
Member
There was a problem hiding this comment.
The values of the following properties of the pointercancel event MUST match the values of the last dispatched pointer event with the same pointerId
I don't think this should be 0.
Member
There was a problem hiding this comment.
I guess we can leave this as a follow-up. Just add a TODO. Btw you haven't pushed your new commit yet.
Contributor
Author
There was a problem hiding this comment.
Let's see if I find time to fix that later today :)
Member
There was a problem hiding this comment.
This doesn't seem to be covered by any tests tho.
webbeef
force-pushed
the
pointer-enter-leave-v2
branch
3 times, most recently
from
2e815ce to
269a42f
Compare
|
🔨 Triggering try run (#22517549670) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22517549670): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (20)
|
|
✨ Try run (#22517549670) succeeded. |
yezhizhen
reviewed
Feb 28, 2026
Member
There was a problem hiding this comment.
The values of the following properties of the pointercancel event MUST match the values of the last dispatched pointer event with the same pointerId
I don't think this should be 0.
I see that you addressed this in the last commit. But it does not change any test results. Do you know why?
If not, maybe we should just revert the last commit for now, and all the comments below does not matter.
| can_gc, | ||
| ) | ||
| } else { | ||
| // Fallback: no prior event stored (shouldn't happen in practice) |
Member
There was a problem hiding this comment.
Let's leave a debug_assertion here.
Comment on lines
+1125
to
+1134
| let pe = pointer_touch.to_pointer_event( | ||
| window, | ||
| pointer_event_name, | ||
| pointer_id, | ||
| is_primary, | ||
| input_event.active_keyboard_modifiers, | ||
| event.is_cancelable(), | ||
| Some(hit_test_result.point_in_node), | ||
| can_gc, | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| let pe = pointer_touch.to_pointer_event( | |
| window, | |
| pointer_event_name, | |
| pointer_id, | |
| is_primary, | |
| input_event.active_keyboard_modifiers, | |
| event.is_cancelable(), | |
| Some(hit_test_result.point_in_node), | |
| can_gc, | |
| ); |
You can inline this.
| }, | ||
| ); | ||
|
|
||
| pe |
| let pressure = if event_type == "pointerup" || event_type == "pointercancel" { | ||
| // Pressure is 0.5 for active touches, 0.0 for up/cancel/out/leave | ||
| let pressure = if event_type == "pointerup" || | ||
| event_type == "pointercancel" || |
Member
There was a problem hiding this comment.
This doesn't seem to be covered by any tests tho.
pointerover Signed-off-by: webbeef <[email protected]>
webbeef
force-pushed
the
pointer-enter-leave-v2
branch
from
269a42f to
e7e9ada
Compare
yezhizhen
approved these changes
Mar 3, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
…erover (servo#42736) Adds support for more pointer events: pointerenter, pointerout, pointerleave, pointerover Also add global event handlers that were missing. Testing: WPT expectations are updated. cc @yezhizhen Signed-off-by: webbeef <[email protected]>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…erover (servo#42736) Adds support for more pointer events: pointerenter, pointerout, pointerleave, pointerover Also add global event handlers that were missing. Testing: WPT expectations are updated. cc @yezhizhen Signed-off-by: webbeef <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for more pointer events: pointerenter, pointerout, pointerleave, pointerover
Also add global event handlers that were missing.
Testing: WPT expectations are updated.
cc @yezhizhen