Merged
Conversation
Contributor
|
r- remove swap file |
Collaborator
|
I don't see a swap file. Also, could you instead add the actual license? Just copy the one from here for example: |
Author
Contributor
|
oops. it contains additional 2 spaces ahead of line starts. |
Merged
|
I get this https://gist.github.com/mcepl/7944780 with c168e04 ... is the same problem or something else? |
Member
|
Different problem, since it appears to be checking non-rust files for license headers. |
|
So, should I file a new bug or is known? |
Member
|
Never heard of it before; please file a new one. |
|
It's #1402 |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Add a test for the Comment constructor.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fixed a number of smoothstep() UB cases in the shaders Fixed the red rectangle in servo#427, but the text is still broken (to be addressed later). The change is similar to servo/webrender@b89ecd1, now all `smoothstep` calls should be correct. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/474) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Text transformation fixes Fixes servo#427 well, mostly... Looks like the transformed clips (servo#498) need to be implemented for this to work fully correct. Also adds a bit of comments to GLSL code to understand what's going on (please check if I misunderstood stuff and documented it wrong!). The errors spotted: 1. `layer.screen_vertices` was fetched with wrong indices 2. `untransform` would use undefined value of `t` if the layer plane is perpendicular to the view 3. text vertex shaders were missing a division by `vi.local_pos.z` for the layer coordinates 4. `prim.local_rect` was used for the text_run local rectangle, instead of `local_rect` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/497) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Local rectangle clipping for transformed primitives Finishes servo#427 implementation, now the text is cut evenly and not aligned to tile borders. Also refactored `build_bounding_rect()` as well as a bit of `assign_prims_to_screen_tiles()`.  <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/502) <!-- Reviewable:end -->
jdm
pushed a commit
to jdm/servo
that referenced
this pull request
Mar 6, 2021
Set the cpp flag on the cc builder in build.rs
Fixes a build error when cross-compiling from linux to android:
```
CC_armv7-linux-androideabi = None
CC_armv7_linux_androideabi = None
HOST_CC = None
CC = None
CFLAGS_armv7-linux-androideabi = None
CFLAGS_armv7_linux_androideabi = None
HOST_CFLAGS = None
CFLAGS = Some("--sysroot /home/servo/android/ndk/r12b/android-ndk-r12b/platforms/android-18/arch-arm -I/home/servo/android/ndk/r12b/android-ndk-r12b/sources/android/support/include")
running: "arm-linux-androideabi-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "--sysroot" "/home/servo/android/ndk/r12b/android-ndk-r12b/platforms/android-18/arch-arm" "-I/home/servo/android/ndk/r12b/android-ndk-r12b/sources/android/support/include" "-g" "-march=armv7-a" "-march=armv7-a" "-mthumb" "-mfpu=vfpv3-d16" "-mfloat-abi=softfp" "-I" "/home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/dist/include" "-Wall" "-Wextra" "-fPIC" "-fno-rtti" "-std=c++11" "-include" "/home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/js/src/js-confdefs.h" "-Wno-c++0x-extensions" "-Wno-return-type-c-linkage" "-Wno-unused-parameter" "-DJS_NO_JSVAL_JSID_STRUCT_TYPES=" "-o" "/home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs-3864977b9602d849/out/src/jsglue.o" "-c" "src/jsglue.cpp"
cargo:warning=In file included from /home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/dist/include/mozilla/Attributes.h:12:0,
cargo:warning= from /home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/dist/include/mozilla/Assertions.h:16,
cargo:warning= from /home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/dist/include/mozilla/AlreadyAddRefed.h:12,
cargo:warning= from /home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/dist/include/jsapi.h:12,
cargo:warning= from src/jsglue.cpp:15:
cargo:warning=/home/servo/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-6ea9cc1d03743689/out/dist/include/mozilla/Compiler.h:49:21: fatal error: cstddef: No such file or directory
cargo:warning= # include <cstddef>
cargo:warning= ^
cargo:warning=compilation terminated.
exit code: 1
```
The error shows that the C compiler chain rather than the C++ compiler chain is being used, even though it's compiling a `.cpp` file.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/427)
<!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i added ''xfail-license' comment.