script: Pass &mut JSContext to Constructor and Wrap#42681
Merged
TimvdLippe merged 2 commits intoservo:mainfrom Feb 17, 2026
Merged
script: Pass &mut JSContext to Constructor and Wrap#42681TimvdLippe merged 2 commits intoservo:mainfrom
&mut JSContext to Constructor and Wrap#42681TimvdLippe merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
servo-highfive
added
the
S-awaiting-review
Contributor
|
@Gae24 do you mind reviewing this one? |
servo-highfive
removed
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 17, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Approving on their behalf
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This was referenced Feb 17, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
…uctor (#42712) #42681 did not actually allowed using cx in Constructor, but it did most heavy lifting. Now we need to pass cx to Constructor call (and skip CanGc) if cx is requested in Bindings.conf. This PR also test this on testbindings. Also we now always use `let cx = &mut cx`, so we can always use just cx (compiler will automatically deref it into &cx if needed). This is important because codegen stuff is called from many places to it make sense/easier to just unify this. Testing: It compiles Signed-off-by: sagudev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Just refactor, but should be covered by WPT
Part of #40600