script: Start using &mut JSContext in devtools and webdriver code#42640
Merged
sagudev merged 4 commits intoservo:mainfrom Feb 16, 2026
Merged
script: Start using &mut JSContext in devtools and webdriver code#42640sagudev merged 4 commits intoservo:mainfrom
&mut JSContext in devtools and webdriver code#42640sagudev merged 4 commits intoservo:mainfrom
Conversation
use CurrentRealm inside `Window::WebdriverCallback`, propagating it to `jsval_to_webdriver` Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 15, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
All of it LGTM, but I don't know yet how to deal with these realms. So pinged @sagudev for these to double-check me.
servo-highfive
removed
the
S-awaiting-review
sagudev
reviewed
Feb 16, 2026
|
🔨 Triggering try run (#22053632891) for Linux (Build libservo) |
|
✨ Try run (#22053632891) succeeded. |
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step to compile scripts using
&mut JSContext.Testing: Refactor, covered by existing WPT tests.
Part of #40600