devtools: Unify pause handling for breakpoints and interrupt #42599
Merged
Conversation
Reuse the logic for pausing breakpoints to pause the debugger when the user manually clicks the pause button (interrupt). Rename the pause event to interrupt to match the language of the DevTools client and to avoid confusion with paused frames, which can happen on interrupt or on a breakpoint. Signed-off-by: eri <[email protected]>
eerii
force-pushed
the
pause_in_breakpoints
branch
from
34d1e5b to
e5b1ed7
Compare
servo-highfive
added
the
S-awaiting-review
eerii
changed the title
atbrakhi
reviewed
Feb 19, 2026
atbrakhi
reviewed
Feb 19, 2026
Member
atbrakhi
left a comment
atbrakhi
left a comment
There was a problem hiding this comment.
This looks great Eri! Let's add a test for manual pause before landing :)
Signed-off-by: eri <[email protected]> Co-authored-by: atbrakhi <[email protected]>
atbrakhi
approved these changes
Feb 22, 2026
Member
atbrakhi
left a comment
atbrakhi
left a comment
There was a problem hiding this comment.
Looks good, thanks for including test! Just some small comments but we should be able to land it after!
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: eri <[email protected]> Co-authored-by: atbrakhi <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
|
hi! just to confirm, is it this patch that makes clicking the pause button actually pause execution, while #42007 just made the button appear to work in the client? or was pausing execution done in another patch, and this patch is only a rework plus adding tests? |
Member
Author
|
Exactly! While pausing was done in #42580, that only worked for breakpoints. This made it work when you click the pause button. |
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…2599) The pause debugger screen should be shown for both pausing manually (interrupt) and hitting a breakpoint. Reuse the logic for pausing breakpoints to pause the debugger when the user manually clicks the pause button. Rename the pause event to interrupt to match the language of the DevTools client and to avoid confusion with paused frames, which can happen on interrupt or on a breakpoint. https://github.com/user-attachments/assets/ceb0007d-0e57-44d6-a159-55980ff8b517 Testing: New DevTools test and manual testing. Part of: servo#36027 cc @atbrakhi --------- Signed-off-by: eri <[email protected]> Co-authored-by: atbrakhi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pause debugger screen should be shown for both pausing manually (interrupt) and hitting a breakpoint.
Reuse the logic for pausing breakpoints to pause the debugger when the user manually clicks the pause button.
Rename the pause event to interrupt to match the language of the DevTools client and to avoid confusion with paused frames, which can happen on interrupt or on a breakpoint.
2026-02-19.09-24-32.mp4
Testing: New DevTools test and manual testing.
Part of: #36027
cc @atbrakhi