stylo: Enable system color#42529
Conversation
|
🔨 Triggering try run (#21891676748) for Linux (WPT) |
|
|
08dd786 to
ed83221
Compare
|
🔨 Triggering try run (#21892315809) for Linux (WPT) |
|
|
ed83221 to
12f83e4
Compare
|
🔨 Triggering try run (#21892434137) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21892434137): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (33)
|
|
|
|
🔨 Triggering try run (#21895149577) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21895149577): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#21895149577) succeeded. |
0646d90 to
c241cac
Compare
|
🔨 Triggering try run (#21939734028) for Linux (WPT) |
Signed-off-by: batu_hoang <[email protected]>
Signed-off-by: batu_hoang <[email protected]>
Signed-off-by: batu_hoang <[email protected]>
Signed-off-by: batu_hoang <[email protected]>
8fdf97a to
8dd0e72
Compare
8dd0e72 to
3962d46
Compare
Enable system color and map keyword to value according to: https://w3c.github.io/csswg-drafts/css-color-4/#valdef-color-canvastext Values not mentioned are set to default. Servo PR: servo/servo#42529 Signed-off-by: batu_hoang <[email protected]>
Signed-off-by: batu_hoang <[email protected]>
Enable system color and map keyword to value according to: https://w3c.github.io/csswg-drafts/css-color-4/#valdef-color-canvastext Values not mentioned are set to default. Servo PR: servo/servo#42529 Signed-off-by: batu_hoang <[email protected]>
Enable system color and map keyword to value according to: https://w3c.github.io/csswg-drafts/css-color-4/#valdef-color-canvastext Values not mentioned are set to default. Servo PR: servo/servo#42529 Signed-off-by: batu_hoang <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
|
This change modified the styling of form controls, which should have been done in a separate change. Instead, this change should have maintained the existing style of form controls by porting the current Servo colors to Stylo or, instead, provided a way for Stylo to override these colors for itself. |
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes (part of #42529) were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. ### Before (with unintended change): <img width="520" height="115" alt="Screenshot 2026-03-09 at 08 47 15" src="https://github.com/user-attachments/assets/cff5fc1a-bfd0-4785-8326-91e735390176" /> ### After (restored style): <img width="499" height="113" alt="Screenshot 2026-03-09 at 08 46 02" src="https://github.com/user-attachments/assets/99660c7f-9eb6-4ee8-905e-f7a594bd363d" /> Testing: These changes are really only testable via the manual test `tests/html/form-control-visuals.html`. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
I believe that these changes were likely made in error. Servo button controls do not follow the system theme, so system colors should not be used. These changes degraded the look of the buttons, so this change reverts to the previous state. Signed-off-by: Martin Robinson <[email protected]>
Enable system color: