Skip to content

Update expected results for paint-timing tests#42525

Merged
jdm merged 1 commit intoservo:mainfrom
shubhamg13:paint_timing_image_key
Feb 11, 2026
Merged

Update expected results for paint-timing tests#42525
jdm merged 1 commit intoservo:mainfrom
shubhamg13:paint_timing_image_key

Conversation

@shubhamg13
Copy link
Copy Markdown
Member

Updates the WPT expectations for #42411.

#42433 changed the expectations recently.

Testing: WPT Tests Passed
Fixes #42359
Fixes #42360

Signed-off-by: Shubham Gupta <[email protected]>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 11, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 11, 2026
@jdm jdm changed the title fixup! layout: Mark Contentful for Images only if they have ImageKey Update expected results for paint-timing tests Feb 11, 2026
@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 11, 2026

I've given this PR a real title.

@jdm jdm added this pull request to the merge queue Feb 11, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 11, 2026
@shubhamg13
Copy link
Copy Markdown
Member Author

I've given this PR a real title.

Just curious, fixup doesn't work in our Project...

Merged via the queue into servo:main with commit b76354f Feb 11, 2026
34 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 11, 2026
@shubhamg13 shubhamg13 deleted the paint_timing_image_key branch February 11, 2026 03:28
@mrobinson
Copy link
Copy Markdown
Member

I've given this PR a real title.

Just curious, fixup doesn't work in our Project...

Fixup commits only work when you can edit the history. You cannot edit the history of a GitHub repository normally via PRs. In general, the PR title should describe what it actually does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent PASS in /paint-timing/fcp-only/fcp-video-frame.html Intermittent PASS in /paint-timing/fcp-only/fcp-video-poster.html

4 participants