script: implement import.meta.resolve#42506
Conversation
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
I am not an expert in mozjs side of things, but given the WPT results I think it's fine? Asked one question about the remaining test failures whether we can also address these in this PR or require more follow-up work.
|
|
||
| [Scope sorting with multiple empty scopes: Multiple empty scopes before specific scope: Import from root bundles should use version1: bar] | ||
| expected: FAIL | ||
|
|
||
| [Scope sorting with multiple empty scopes: Multiple empty scopes before specific scope: Import from asdfasdf should use version1 (empty scope): bar] |
There was a problem hiding this comment.
Is there any particular reason we are still failing those? Are those for other reasons than the current implementation?
There was a problem hiding this comment.
I've not investigated it yet, but it's probably due to some corner case of resolve a module specifier that we are missing.
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
The code looks okay to me and given so many WPT tests start to pass, let's merge this. Do try to figure out in a follow-up how to fix the remaining test failures. Maybe there is an underlying issue that we can resolve (no pun intended).
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
3 participants
Our implementation of HostGetImportMetaProperties wasn't providing
resolvefunction to mozjs.Testing: Covered by existing tests, results updated
Part of #37553