webdriver: make pen inputs behave like mouse#42485
webdriver: make pen inputs behave like mouse#42485webbeef wants to merge 1 commit intoservo:mainfrom
Conversation
This aligns with the expectations in tests/wpt/tests/pointerevents/pointerevent_attributes.html that classifies pen and mouse as 'hover' pointers, and touch as 'non hover'. Signed-off-by: webbeef <[email protected]>
servo-highfive
added
the
S-awaiting-review
|
cc @yezhizhen |
There was a problem hiding this comment.
Let's revert this part in #41290 (review) and get that merged first, so that we can see the impact of this clearly.
This is like #41819: there is no need to rush this. We don't support pen embedder type right now anyway.
servo-highfive
added
S-needs-code-changes
|
The distinction is described in https://w3c.github.io/pointerevents/#mapping-for-devices-that-do-not-support-hover in terms of supporting hover or not. I checked online and electronic pencils can actually support hover, sending events without physical contact with the screen / drawing area. |
This is true and have been the case for many years. But my concern is always the lack of embedder pen type. Anyway, can you rebase and update expectation first? |
|
Try run after rebase: https://github.com/webbeef/servo/actions/runs/21935044148/job/63351784939 At least the regression in |
It looks like this will be available in winit 0.31 : https://github.com/rust-windowing/winit/blob/f98ccf8efc5e3f6dd3e31b705178603f6556d316/winit-core/src/event.rs#L1057 Maybe we should wait for that and then figure out what that means for our input pipeline? |
3 participants
This aligns with the expectations in tests/wpt/tests/pointerevents/pointerevent_attributes.html that classifies pen and mouse as 'hover' pointers, and touch as 'non hover'.
Testing: Green try run at https://github.com/webbeef/servo/actions/runs/21832655621