script: Fix crash when failed requests finish from a previous generation by TimvdLippe · Pull Request #42481 · servo/servo

TimvdLippe · 2026-02-09T15:09:22Z

Most likely a regression introduced in #42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests).

Fixes #42477

github-actions · 2026-02-09T15:11:37Z

🔨 Triggering try run (#21830474358) for Linux (WPT)

TimvdLippe · 2026-02-09T15:11:57Z

Verified that ./mach test-wpt /css/cssom/HTMLLinkElement-load-event-002.html --repeat-until-unexpected passes for 30 runs, which was the original issue in #42187

servo-wpt-sync · 2026-02-09T15:15:16Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57650) with upstreamable changes.

github-actions · 2026-02-09T16:08:40Z

Test results for linux-wpt from try job (#21830474358):

Flaky unexpected result (30)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory-databases-opaque-origin.html
- FAIL [expected PASS] subtest: IDBFactory.databases() in non-sandboxed iframe should not reject
```
assert_equals: IDBFactory.databases() should not reject expected "no exception" but got "OperationError"
```

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

TIMEOUT [expected OK] /_mozilla/mozilla/img_find_non_sibling_map.html
CRASH [expected OK] /_webgl/conformance/attribs/gl-vertex-attrib-render.html

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 10 more unexpected results...

OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
OK /css/css-fonts/generic-family-keywords-002.html (#40929)
- FAIL [expected PASS] subtest: font-family: -webkit-serif treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-sans-serif treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-cursive treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-fantasy treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-monospace treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-system-ui treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-math treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- PASS [expected FAIL] subtest: font-family: -webkit-generic(fangsong) treated as <font-family>, not <generic-name>
- PASS [expected FAIL] subtest: font-family: -webkit-generic(kai) treated as <font-family>, not <generic-name>
- PASS [expected FAIL] subtest: font-family: -webkit-generic(khmer-mul) treated as <font-family>, not <generic-name>
- And 12 more unexpected results...
FAIL [expected PASS] /css/css-ui/webkit-appearance-menulist-button-001.html

OK /css/css-values/cap-invalidation.html

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

Unhandled rejection: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK [expected ERROR] /fetch/fetch-later/quota/cross-origin-iframe/sandboxed-iframe.https.window.html
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-initial-navigation.html (#40387)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected TIMEOUT] /html/editing/dnd/interactiveelements/draggable_input_image.html
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-top.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with "top" fragments should work.
```
Test timed out
```

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-window-open.html (#32596)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: location.replace

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /paint-timing/fcp-only/input-text.html (#42439)
- FAIL [expected PASS] subtest: Text from a form control triggers First Contentful Paint.
```
assert_equals: First contentful paint marked too early.  expected 0 but got 1
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
TIMEOUT [expected OK] /visual-viewport/resize-event-order.html (#41981)
- TIMEOUT [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: iframe: DOMWindow resize fired before VisualViewport.
PASS [expected TIMEOUT] /visual-viewport/viewport-apply-initial-scale-after-navigation.html (#41582)

OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)

FAIL [expected PASS] subtest: buffer-stitching-2

assert_approx_equals: Stitched sine‑wave buffers at sample rate 43800 sample[7371] |1.2676905976393216e+26 - -0.2660368084907532| = 1.2676905976393216e+26 &gt; 0.0038986 expected -0.2660368084907532 +/- 0.0038986 but got 1.2676905976393216e+26

OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
OK /webxr/xrSession_features_deviceSupport.https.html (#24357)
- FAIL [expected PASS] subtest: Immersive XRSession requests with no supported device should reject
```
assert_unreached: Should have rejected: undefined Reached unreachable code
```

Stable unexpected results that are known to be intermittent (25)

OK [expected ERROR] /IndexedDB/cursor-overloads.any.worker.html (#42324)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(kai)
```
assert_equals: quoted generic(kai) matches  @font-face rule expected 50 but got 30
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
```
assert_equals: quoted generic(nastaliq) matches  @font-face rule expected 50 but got 30
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-rounded (drawing text in a canvas)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-mode
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-mode - Not sent to non-trustworthy same-site destination
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
CRASH [expected TIMEOUT] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: can't access property "appendChild", w.document.querySelector(...) is null"

OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- FAIL [expected PASS] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
```
uncaught exception: Error: assert_unreached: The iframe from which the meta came from must not refresh Reached unreachable code
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- PASS [expected FAIL] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- TIMEOUT [expected FAIL] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
Test timed out
```
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- FAIL [expected PASS] subtest: Video should seek to time specified in media fragment syntax
```
assert_equals: expected 3 but got 0
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
OK /paint-timing/fcp-only/fcp-with-rtl.html (#42357)
- FAIL [expected PASS] subtest: FCP should fire when coordinates are negative, if within document scrollable area
```
assert_equals: First contentful paint marked too early.  expected 0 but got 1
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
```
assert_equals: expected 54.44999999999999 but got 54.45
```
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```

github-actions · 2026-02-09T16:08:49Z

✨ Try run (#21830474358) succeeded.

mrobinson

Just a minor nit:

components/script/stylesheet_loader.rs

Most likely a regression introduced in servo#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes servo#42477 Signed-off-by: Tim van der Lippe <[email protected]>

servo-wpt-sync · 2026-02-09T18:27:10Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57650).

servo-wpt-sync · 2026-02-10T07:40:18Z

⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#57650). Please address any CI issues and try to merge manually.

TimvdLippe requested a review from gterzian as a code owner February 9, 2026 15:09

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Feb 9, 2026

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 9, 2026

TimvdLippe mentioned this pull request Feb 9, 2026

panic: What finished? (thread Script#1, at components/script/dom/html/htmllinkelement.rs:901) #42477

Closed

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 9, 2026

servo-wpt-sync mentioned this pull request Feb 9, 2026

script: Fix crash when failed requests finish from a previous generation web-platform-tests/wpt#57650

Merged

mrobinson approved these changes Feb 9, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 9, 2026

mrobinson reviewed Feb 9, 2026

View reviewed changes

components/script/stylesheet_loader.rs Outdated Show resolved Hide resolved

TimvdLippe force-pushed the fix-failed-link-request-pending-loads branch from 0839f19 to cc58570 Compare February 9, 2026 18:23

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 9, 2026

TimvdLippe enabled auto-merge February 9, 2026 18:25

TimvdLippe added this pull request to the merge queue Feb 9, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 9, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 9, 2026

TimvdLippe added this pull request to the merge queue Feb 10, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 10, 2026

Merged via the queue into servo:main with commit 8ae4cbe Feb 10, 2026
39 checks passed

TimvdLippe deleted the fix-failed-link-request-pending-loads branch February 10, 2026 07:39

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Fix crash when failed requests finish from a previous generation#42481

script: Fix crash when failed requests finish from a previous generation#42481
TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe:fix-failed-link-request-pending-loads

TimvdLippe commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

TimvdLippe commented Feb 9, 2026

Uh oh!

servo-wpt-sync commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

mrobinson left a comment

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

TimvdLippe commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

TimvdLippe commented Feb 9, 2026

Uh oh!

servo-wpt-sync commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

mrobinson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants