IndexedDB: Throw InvalidStateError if object store is deleted in createIndex/deleteIndex#42443
IndexedDB: Throw InvalidStateError if object store is deleted in createIndex/deleteIndex#42443jdm merged 2 commits intoservo:mainfrom
Conversation
…teIndex/deleteIndex Signed-off-by: bulltickr <[email protected]>
1ca460a to
03beeca
Compare
arihant2math
left a comment
There was a problem hiding this comment.
LGTM code-wise. You need to follow https://book.servo.org/contributing/testing.html#updating-web-platform-test-expectations to update the expectation files.
Signed-off-by: bulltickr <[email protected]>
thanks is this ok ? |
|
🔨 Triggering try run (#21795362893) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21795362893): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (1)
|
|
|
|
🔨 Triggering try run (#21795880446) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21795880446): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (21)
|
|
✨ Try run (#21795880446) succeeded. |
|
Hi, I’d like to work on this issue. If it’s still available, |
After the changes from #42443, there are no longer any unhandled errors in the`idbobjectstore_createIndex.any.worker.html` tests, so the result is `TIMEOUT` rather than `ERROR`. Also remove the now-passing test labels for consistency with other `.ini` files. Testing: No unexpected results in `idbobjectstore_createIndex.any.worker.html`, the tests now run as expected. Fixes: #42445 Signed-off-by: pralkarz <[email protected]>
This PR adds a check to ensure that createIndex and deleteIndex throw an InvalidStateError if the object store has been deleted, aligning with the W3C spec.
I checked the spec to make sure the error check happens in the right order (checking the transaction mode before the deleted state). I've verified this with the Web Platform Tests, and the createIndex test is now passing.
Fixes #42436