indexeddb: Update index data in backend#42416
Open
arihant2math wants to merge 8 commits intoservo:mainfrom
Open
indexeddb: Update index data in backend#42416arihant2math wants to merge 8 commits intoservo:mainfrom
arihant2math wants to merge 8 commits intoservo:mainfrom
Conversation
arihant2math
changed the title
6 tasks
arihant2math
force-pushed
the
idb-index-backend
branch
2 times, most recently
from
b31613a to
69acff2
Compare
|
🔨 Triggering try run (#21771587035) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21771587035): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (35)
|
|
✨ Try run (#21771587035) succeeded. |
Contributor
Author
|
ETA: It does deserialization on a JS thread |
servo-highfive
added
the
S-awaiting-review
arihant2math
force-pushed
the
idb-index-backend
branch
2 times, most recently
from
8f5b11b to
a2b2ead
Compare
Contributor
Author
|
So I think it's safe to put of that discussion for later. However, I do want to have some testing for this PR, so I'll implement some of the script methods. |
|
🔨 Triggering try run (#21806059338) for Linux (WPT) |
|
|
arihant2math
force-pushed
the
idb-index-backend
branch
2 times, most recently
from
3d0a23c to
efdda4f
Compare
|
🔨 Triggering try run (#21807087904) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21807087904): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (15)
|
|
|
arihant2math
force-pushed
the
idb-index-backend
branch
from
a65eba7 to
9aa66aa
Compare
|
🔨 Triggering try run (#22235890609) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22235890609): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (4)
|
|
|
|
🔨 Triggering try run (#22237077389) for Linux (WPT) |
arihant2math
force-pushed
the
idb-index-backend
branch
from
9aa66aa to
e2b1eb4
Compare
|
🔨 Triggering try run (#22238236850) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22237077389): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (4)
|
|
|
|
Test results for linux-wpt from try job (#22238236850): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (18)
|
|
✨ Try run (#22238236850) succeeded. |
Taym95
reviewed
Feb 23, 2026
Member
Taym95
left a comment
Taym95
left a comment
There was a problem hiding this comment.
can we Rename variables to avoid confusion?
primary_key (IDB key for object_data row)
index_key (single key inserted into index row)
index_key_value / extracted_index_key (outer tuple field)
took me some time to figure it out
| ) -> Result<Option<index_data_model::Model>, Error> { | ||
| let index = Self::get_index(connection, &store, index)?; | ||
| let (sql, values) = if index.unique_index { | ||
| let query = range_to_query(&key_range, unique_index_data_model::Column::ObjectDataKey); |
Member
There was a problem hiding this comment.
using ObjectDataKey correct here? same for index_get_all, index_count?
| index: String, | ||
| key_range: IndexedDBKeyRange, | ||
| ) -> Result<Option<Vec<u8>>, Error> { | ||
| Self::index_get(connection, store, index, key_range).map(|opt| opt.map(|model| model.value)) |
Member
There was a problem hiding this comment.
I think(from the spec) IDBIndex.getKey() should return the primary key?
| key_range: IndexedDBKeyRange, | ||
| ) -> Result<Option<Vec<u8>>, Error> { | ||
| Self::index_get(connection, store, index, key_range) | ||
| .map(|opt| opt.map(|model| model.object_data_key)) |
Member
There was a problem hiding this comment.
is this mapped to IDBIndex.get() ? if so function should return the stored object value
| count: Option<u32>, | ||
| ) -> Result<Vec<Vec<u8>>, Error> { | ||
| Self::index_get_all(connection, store, index, key_range, count) | ||
| .map(|models| models.into_iter().map(|m| m.object_data_key).collect()) |
Member
There was a problem hiding this comment.
getAll should to return object values or primary keys ?
| // Step 5. | ||
| let serialized_index_key: Vec<u8> = postcard::to_stdvec(&key).unwrap(); | ||
| connection.execute( | ||
| "INSERT INTO unique_index_data (index_id, object_data_key, value, object_store_id) VALUES (?, ?, ?, ?)", |
Member
There was a problem hiding this comment.
This does not remove old index rows for this primary key, is this spec compliance?
components/storage/indexeddb/engines/sqlite/index_data_model.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
arihant2math
force-pushed
the
idb-index-backend
branch
from
e2b1eb4 to
9cd8221
Compare
Contributor
Author
Yeah, I borrowed those names off of firefox, probably not the best idea in the long run. |
Signed-off-by: Ashwin Naren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates indices in the course of regular object store operations. Also allows for querying of indices.
Followups:
Testing: More WPT tests
Fixes: Partially #38100