layout: Mark Contentful for Images only if they have ImageKey#42411
layout: Mark Contentful for Images only if they have ImageKey#42411TimvdLippe merged 1 commit intoservo:mainfrom
Contentful for Images only if they have ImageKey#42411Conversation
|
🔨 Triggering try run (#21757171318) for Linux (WPT) |
bc878f7 to
ea98bf9
Compare
Signed-off-by: Shubham Gupta <[email protected]>
ea98bf9 to
06e8f04
Compare
|
Test results for linux-wpt from try job (#21757171318): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (33)
|
|
✨ Try run (#21757171318) succeeded. |
|
🔨 Triggering try run (#21769583122) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21769583122): Flaky unexpected result (21)
Stable unexpected results that are known to be intermittent (41)
|
|
✨ Try run (#21769583122) succeeded. |
|
🔨 Triggering try run (#21774915917) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21774915917): Flaky unexpected result (25)
Stable unexpected results that are known to be intermittent (30)
|
|
✨ Try run (#21774915917) succeeded. |
|
🔨 Triggering try run (#21775487908) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21775487908): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#21775487908) succeeded. |
|
@shubhamg13 running WPT is quite expensive, so we try to be conservative when running. Is there a particular reason you ran it four times in a row without changes to the PR? |
Yes to make sure Intermittent tests, which I'm targeting, are fixed. I will take care of this from onwards 🙂 |
|
You can run these locally with |
|
Yeah, I know. I already ran 20+ on my local system. I will remember this from next time. |
Contentful for Images only if they have ImageKey
Updates the WPT expectations for #42411. #42433 changed the expectations recently. Testing: WPT Tests Passed Fixes #42359 Fixes #42360 Signed-off-by: Shubham Gupta <[email protected]>
|
cc: @xiaochengh |
This PR checks if
ImageKeyis available, then it marks it asContentful. For Videos, if validposterorfirst frame, it will be stored inImageKey.Hence, appropriate way to mark
Contentful.Testing:
/paint-timing/fcp-only/fcp-video-poster.html/paint-timing/fcp-only/fcp-video-frame.htmlFixes #42359
Fixes #42360