Bump accesskit version and patch egui to use updated accesskit#42402
Bump accesskit version and patch egui to use updated accesskit#42402delan merged 1 commit intoservo:mainfrom
Conversation
|
It seems like there are a lot of unrelated changes in egui ToT which cause warnings which are quite difficult to address (after trying for a day to address them). |
|
I've done my best to address the deprecation warnings, though I've still needed to add an I'm marking this as ready for review, but I'm anticipating still needing to make significant changes - in particular, this bumps the rust toolchain version, which might be better as a separate patch? |
servo-highfive
added
the
S-awaiting-review
alice
force-pushed
the
bump-accesskit-egui
branch
from
911406d to
8a532a9
Compare
alice
force-pushed
the
bump-accesskit-egui
branch
from
364e42f to
71996a6
Compare
This is a prerequisite for using the new version of egui introduced in #42402. Testing: No new behaviour. Signed-off-by: Alice Boxhall <[email protected]>
alice
force-pushed
the
bump-accesskit-egui
branch
from
41d7fd3 to
b2871b7
Compare
i agree, we should split the rust bump into its own patch. the todos should be tracked in an issue if we’re keeping any of them, but i wonder if it would make more sense to use an egui commit where we apply emilk/egui#7850 to the egui version we’re currently on? that way, we avoid dealing with all those other breaking changes until they are definitely in a release, stable and fully documented. |
alice
force-pushed
the
bump-accesskit-egui
branch
3 times, most recently
from
d616c97 to
e90831c
Compare
I've done this :) |
Signed-off-by: Alice Boxhall <[email protected]>
alice
force-pushed
the
bump-accesskit-egui
branch
from
e90831c to
279a588
Compare
delan
changed the title
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
4 participants
We need to bump the accesskit version in order to use subtrees, which are required to join the servo tree into the embedder tree.
We need to patch egui for servoshell, as we're waiting for them to land the patch bumping their version of accesskit.
Once emilk/egui#7850 lands and a new version of egui is pushed out, we'll be able to remove the patch.
Testing: No tests.
Fixes: Part of #4344