testdriver harness: Allow duration 0 for actions/tick#42398
testdriver harness: Allow duration 0 for actions/tick#42398yezhizhen merged 2 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#21747800752) for Linux (WPT) |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57607) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57607) title and body. |
1 similar comment
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57607) title and body. |
|
Shouldn't these kind of PRs be made and reviewed upstream? |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57607). |
#42158 (comment). |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57607) title and body. |
|
🔨 Triggering try run (#21748939786) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21747800752): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (35)
Stable unexpected results (2)
|
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Test results for linux-wpt from try job (#21748939786): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (32)
Stable unexpected results (1)
|
|
|
This comment was marked as outdated.
This comment was marked as outdated.
|
The failure is because the test itself is wrong. We cannot pass a Element as duration. |
…s-video_touch.html` (#42405) The syntax is wrong. We cannot pass an Element as duration. Only Firefox [was passing this](https://wpt.fyi/results/pointerevents/pointerevent_touch-propagates-when-target-is-video_touch.html?run_id=5098406608633856&run_id=5170937667518464&run_id=4715813002280960&run_id=5136051728547840), which is a bug of geckodriver: Testing: Updated expectation of existing tests. This blocks #42398, #42387. Signed-off-by: Euclid Ye <[email protected]>
32a0db0 to
0d3abc0
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57607). |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57607) title and body. |
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
0d3abc0 to
65503f3
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57607). |
|
Another interesting difference from Python conformance is: servo/tests/wpt/tests/resources/testdriver-actions.js Lines 34 to 38 in c6fbaf3 This always insert // 120 HZ
await new test_driver.Actions(defaultTickDuration = 8)
.pointerMove(45, 45, { origin: "viewport"})
.pointerDown() |
|
⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#57607). Please address any CI issues and try to merge manually. |
Previously, even if you explicitly set duration 0, it still ends up with
None.But you can set duration 0 in wdspec python tests.
This complies with spec: duration can be greater than or equal to 0.
Testing: There is no existing testdriver tests that use duration 0.
Fixes: web-platform-tests/wpt#57606
Found in: #42387 (comment)