Skip to content

CI: Add uv.lock to all sparse-checkouts#42353

Merged
sagudev merged 4 commits intomainfrom
sagudev-patch-2
Feb 5, 2026
Merged

CI: Add uv.lock to all sparse-checkouts#42353
sagudev merged 4 commits intomainfrom
sagudev-patch-2

Conversation

@sagudev
Copy link
Copy Markdown
Member

@sagudev sagudev commented Feb 5, 2026

Fixes #42352

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@sagudev sagudev changed the title CI Add uv.lock to sparse-checkout for try label CI: Add uv.lock to sparse-checkout for try label Feb 5, 2026
@yezhizhen yezhizhen added the T-linux-wpt Do a try run of the WPT label Feb 5, 2026
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

🔨 Triggering try run (#21702696449) for Linux (WPT)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

⚠️ Try run (#21702696449) cancelled.

@yezhizhen
Copy link
Copy Markdown
Member

Need to trigger with ./mach try I guess.. Just cancelled the workflow.

@sagudev
Copy link
Copy Markdown
Member Author

sagudev commented Feb 5, 2026

Try label runs use files from main, so we cannot really test this without pushing on main. mach try uses other workflow so it won't help either.

Copy link
Copy Markdown
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@yezhizhen
Copy link
Copy Markdown
Member

Try label runs use files from main, so we cannot really test this without pushing on main. mach try uses other workflow so it won't help either.

The issue also happens with try.
https://github.com/servo/servo/actions/runs/21681834109

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@sagudev sagudev changed the title CI: Add uv.lock to sparse-checkout for try label CI: Add uv.lock to all sparse-checkouts Feb 5, 2026
@sagudev sagudev enabled auto-merge February 5, 2026 07:39
@sagudev sagudev disabled auto-merge February 5, 2026 07:40
Signed-off-by: sagudev <[email protected]>
@yezhizhen
Copy link
Copy Markdown
Member

actually this is wrong

Curious why👀

@sagudev sagudev enabled auto-merge February 5, 2026 07:45
@sagudev sagudev added this pull request to the merge queue Feb 5, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 5, 2026
Merged via the queue into main with commit ce513d5 Feb 5, 2026
29 checks passed
@sagudev sagudev deleted the sagudev-patch-2 branch February 5, 2026 08:48
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning from try/try-label

4 participants