perf tests: Fix minor issues in blink layout tests runner#42346
Merged
jschwe merged 2 commits intoservo:mainfrom Feb 5, 2026
Merged
perf tests: Fix minor issues in blink layout tests runner#42346jschwe merged 2 commits intoservo:mainfrom
jschwe merged 2 commits intoservo:mainfrom
Conversation
- Catch MaxRetryError exception and retry, to avoid logging warnings. This was observed on macos and can happen during startup of servo. - Change the default port, since 7000 was reported by multiple people to cause "port in use" errors. Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
jschwe
changed the title
nicoburns
reviewed
Feb 4, 2026
| try: | ||
| driver = webdriver.Remote(command_executor=f"http://127.0.0.1:{webdriver_port}", options=options) | ||
| except (ConnectionError, ProtocolError): | ||
| except (ConnectionError, ProtocolError, MaxRetryError): |
Contributor
There was a problem hiding this comment.
If we catch the MaxRetryError won't this loop infinitely in the case of failure?
Member
Author
There was a problem hiding this comment.
No, we have a while loop around this that measures time.
Signed-off-by: Jonathan Schwender <[email protected]>
nicoburns
approved these changes
Feb 4, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Manual testing