script: Remove named window proxy map entry when destroying nested browsing context#42344
Merged
jdm merged 1 commit intoservo:mainfrom Feb 4, 2026
Merged
script: Remove named window proxy map entry when destroying nested browsing context#42344jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Member
Author
|
This is known to fix timing out tests in #42254 but there's no reason to make that PR even bigger. |
jdm
force-pushed
the
remove-window-proxy
branch
from
169cde5 to
dbad287
Compare
…owsing context. Signed-off-by: Josh Matthews <[email protected]>
jdm
force-pushed
the
remove-window-proxy
branch
from
dbad287 to
e0861c3
Compare
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57570) with upstreamable changes. |
Collaborator
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#57570). |
sagudev
approved these changes
Feb 4, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving the entries sitting around both unnecessarily increases memory usage and breaks code that looks up window proxies by name and reuses names for iframes within the same page.
Testing: Newly-passing tests.
Fixes: #15258