Skip to content

script: use &mut JSContext inside workers PostMessage api#42342

Merged
sagudev merged 1 commit intoservo:mainfrom
Gae24:workers-postmessage
Feb 4, 2026
Merged

script: use &mut JSContext inside workers PostMessage api#42342
sagudev merged 1 commit intoservo:mainfrom
Gae24:workers-postmessage

Conversation

@Gae24
Copy link
Copy Markdown
Contributor

@Gae24 Gae24 commented Feb 4, 2026

Switch PostMessage of Worker, DedicatedWorkerGlobalScope and ServiceWoker to use &mut JSContext, propagating it to post_message_impl.

Testing: A successful build is enough

@Gae24 Gae24 requested a review from gterzian as a code owner February 4, 2026 16:53
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@Gae24
Copy link
Copy Markdown
Contributor Author

Gae24 commented Feb 4, 2026

There haven’t been many pull requests to convert to &mut JSContext yet.
Should we start opening sub‑issues to kick things off?

@sagudev
Copy link
Copy Markdown
Member

sagudev commented Feb 4, 2026

There haven’t been many pull requests to convert to &mut JSContext yet. Should we start opening sub‑issues to kick things off?

Yes please! Fell free to ping me on any questions or for requesting reviews.

@sagudev
Copy link
Copy Markdown
Member

sagudev commented Feb 4, 2026

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@sagudev sagudev added this pull request to the merge queue Feb 4, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 4, 2026
Merged via the queue into servo:main with commit 97aac6e Feb 4, 2026
32 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 4, 2026
@Gae24 Gae24 deleted the workers-postmessage branch February 5, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants