Skip to content

fix(background_hang_monitor): Use DummySampler on Windows ARM64#42341

Merged
jdm merged 2 commits intoservo:mainfrom
npiesco:fix/arm64-windows-dummy-sampler
Feb 6, 2026
Merged

fix(background_hang_monitor): Use DummySampler on Windows ARM64#42341
jdm merged 2 commits intoservo:mainfrom
npiesco:fix/arm64-windows-dummy-sampler

Conversation

@npiesco
Copy link
Copy Markdown
Contributor

@npiesco npiesco commented Feb 4, 2026 •
edited
Loading

Windows ARM64 (aarch64, MSVC) does not support native profiling. PR updates platform configuration to route Windows ARM64 to DummySampler, aligning it with other unsupported targets (e.g., Linux musl) and fixing build compatibility.

PR #42312

  • Updates platform configuration + conditional compilation
  • Background hang monitor (lib.rs) now selects DummySampler on Windows ARM64
  • Uses DummySampler as SamplerImpl for aarch64 Windows

build/compatibility fix only.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@npiesco npiesco force-pushed the fix/arm64-windows-dummy-sampler branch from 9286508 to 8f018fa Compare February 4, 2026 16:47
@npiesco npiesco mentioned this pull request Feb 4, 2026
Open
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@sagudev sagudev enabled auto-merge February 4, 2026 18:41
@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 4, 2026

@npiesco Did you use an LLM to write the pull request description? If so, please read the rules around LLM contributions at https://book.servo.org/contributing/getting-started.html#ai-contributions.

@sagudev sagudev disabled auto-merge February 4, 2026 18:52
@npiesco
Copy link
Copy Markdown
Contributor Author

npiesco commented Feb 4, 2026

@npiesco Did you use an LLM to write the pull request description? If so, please read the rules around LLM contributions at https://book.servo.org/contributing/getting-started.html#ai-contributions.

Ahhh yes sorry didn't see this, I used the copilot generate summary feature. I will re-do it in my own words manually

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@jdm jdm enabled auto-merge February 4, 2026 19:46
@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 5, 2026

You will need to run ./mach fmt so the linter checks pass. Also, no need to keep pressing the "update branch" button. It doesn't matter if the branch us up to date, as long as there are no merge conflicts.

auto-merge was automatically disabled February 5, 2026 14:06

Head branch was pushed to by a user without write access

@npiesco
Copy link
Copy Markdown
Contributor Author

npiesco commented Feb 5, 2026

You will need to run ./mach fmt so the linter checks pass. Also, no need to keep pressing the "update branch" button. It doesn't matter if the branch us up to date, as long as there are no merge conflicts.

Pushed formatting fix, linter checks should pass now, thanks!

@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 5, 2026

Now you will need to.make sure you have signed off on the new commit :) You can rebase with --signoff to do that automatically.

@npiesco
fix(background_hang_monitor): Use DummySampler on Windows ARM64
80cbe87 
Windows ARM64 (aarch64-pc-windows-msvc) doesn't have native profiling
support in the background hang monitor. Add it to the list of platforms
that use DummySampler, alongside Linux musl and other unsupported targets.

Part of Windows ARM64 build support: servo#42312

Signed-off-by: npiesco <[email protected]>
@npiesco
style: run mach fmt
48b1bea 
Signed-off-by: npiesco <[email protected]>
@npiesco
Copy link
Copy Markdown
Contributor Author

npiesco commented Feb 5, 2026

Now you will need to.make sure you have signed off on the new commit :) You can rebase with --signoff to do that automatically.

LOL keep forgetting that one. I think this is my 5th time now.

@npiesco npiesco force-pushed the fix/arm64-windows-dummy-sampler branch from d425a56 to 48b1bea Compare February 5, 2026 18:35
@jdm jdm enabled auto-merge February 6, 2026 02:47
@jdm jdm added this pull request to the merge queue Feb 6, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 6, 2026
Merged via the queue into servo:main with commit aa5854f Feb 6, 2026
29 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagudev sagudev sagudev approved these changes

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@npiesco @jdm @sagudev @servo-highfive