Skip to content

config: Add a pref for the experimental accessibility code#42333

Merged
mrobinson merged 2 commits intoservo:mainfrom
alice:accessibility_pref
Feb 10, 2026
Merged

config: Add a pref for the experimental accessibility code#42333
mrobinson merged 2 commits intoservo:mainfrom
alice:accessibility_pref

Conversation

@alice
Copy link
Copy Markdown
Contributor

@alice alice commented Feb 4, 2026

This adds a pref which will be used to enable the experimental accessibility tree.

Testing: No testing: just adds a pref which is currently unused.
Fixes: part of #4344

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@delan delan changed the title Add a pref for the experimental accessibility code. Add a pref for the experimental accessibility code Feb 4, 2026
@delan delan self-requested a review February 5, 2026 11:51
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@delan delan added this pull request to the merge queue Feb 5, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 5, 2026
@delan delan removed this pull request from the merge queue due to a manual request Feb 5, 2026
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 5, 2026
@alice alice force-pushed the accessibility_pref branch from f665063 to 652731a Compare February 5, 2026 13:26
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 5, 2026
@alice alice marked this pull request as draft February 5, 2026 13:29
@alice alice force-pushed the accessibility_pref branch 2 times, most recently from f274ea9 to 37e7315 Compare February 6, 2026 10:48
@delan delan requested a review from mrobinson February 6, 2026 11:01
Copy link
Copy Markdown
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

/// Whether or not the viewport meta tag is enabled.
pub viewport_meta_enabled: bool,
pub log_filter: String,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultra nit: Maybe remove this newline to make spacing consistent with the other members.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Co-authored-by: delan azabani <[email protected]>
Signed-off-by: Alice Boxhall <[email protected]>
@alice alice force-pushed the accessibility_pref branch from 37e7315 to b4882cf Compare February 10, 2026 13:36
@alice alice marked this pull request as ready for review February 10, 2026 13:37
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 10, 2026
@mrobinson mrobinson changed the title Add a pref for the experimental accessibility code config: Add a pref for the experimental accessibility code Feb 10, 2026
@mrobinson mrobinson added this pull request to the merge queue Feb 10, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 10, 2026
Merged via the queue into servo:main with commit 60efb42 Feb 10, 2026
30 of 31 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 10, 2026
@alice alice deleted the accessibility_pref branch February 11, 2026 08:30
github-merge-queue bot pushed a commit that referenced this pull request Feb 20, 2026
this patch adds a Servo::set_accessibility_active() method that
embedders can use to tell Servo to start building and sending
accessibility trees to the platform, as long as the pref is enabled
(#42333). doing so sets a global flag in the constellation, which is
then propagated to the layout of all existing and future pipelines.

Testing: none yet, no functional change
Fixes: part of #4344

---------

Signed-off-by: delan azabani <[email protected]>
Signed-off-by: Alice Boxhall <[email protected]>
Co-authored-by: Alice Boxhall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants