layout: Do not consider pseudo-elements widgets for the purposes of replaced content#42332
Conversation
|
🔨 Triggering try run (#21676698264) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21676698264): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (34)
|
|
✨ Try run (#21676698264) succeeded. |
0575d72 to
1ab8f6c
Compare
|
🔨 Triggering try run (#21678986849) for Linux (WPT) |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57567) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57567) title and body. |
|
Test results for linux-wpt from try job (#21678986849): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#21678986849) succeeded. |
Loirooriol
left a comment
There was a problem hiding this comment.
It feels like we just keep putting band-aids, while the root of the problem remains unaddressed.
Which is that, ServoLayoutElement::shadow_root() (and several other methods) shouldn't blindly redirect to self.element, ignoring self.pseudo_element_chain.
But while not fixing that, instead of checking for video and audio replaced kinds, I would check that the pseudo_element_chain is empty. Because I'm not sure we can't rely on pseudo-elements never supporting videos in the future.
1ab8f6c to
3bfa82b
Compare
|
🔨 Triggering try run (#21705262374) for Linux (WPT) |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57567). |
3bfa82b to
dc31513
Compare
|
@Loirooriol is there an issue about the issue we keep bandaging? |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57567). |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57567) title and body. |
|
Test results for linux-wpt from try job (#21705262374): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (35)
|
|
✨ Try run (#21705262374) succeeded. |
dc31513 to
6e37bb0
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57567). |
tests/wpt/tests/html/rendering/the-details-element/details-display-list-item-crash.html
Outdated
Show resolved
Hide resolved
tests/wpt/tests/html/rendering/the-details-element/details-display-list-item-crash.html
Outdated
Show resolved
Hide resolved
When an element has an image content value or list-style-image value they end up duplicating the content of the element inside the generated '::marker'. This is caused by code inside IndependentFormattingContext for user agent widgets (all user agent shadow dom), this code is specifically aimed at video and audio elements. This patch adapts that code to be more specific to elements without a pseudo-element chain (e.g. audio and video) Signed-off-by: Luke Warlow <[email protected]>
Signed-off-by: Luke Warlow <[email protected]>
6e37bb0 to
e175864
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57567). |
Signed-off-by: Luke Warlow <[email protected]>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57567). |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57567) title and body. |
1 similar comment
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57567) title and body. |
When an element has an image content value or list-style-image value they end up duplicating the content of the element inside the generated '::marker'.
This is caused by code inside IndependentFormattingContext for user agent widgets (all user agent shadow dom), this code is specifically aimed at video and audio elements.
This patch adapts that code to be more specific to elements without a pseudo-element chain (e.g. audio and video)
Testing: newly added test crashes on main servo (slightly flakily), but passes consistently now.
Fixes: #42329
Fixes: #41231