Skip to content

paint: Reduce unnecessary memory reallocation/mutable getter#42328

Merged
yezhizhen merged 5 commits intoservo:mainfrom
yezhizhen:remove-mut
Feb 4, 2026
Merged

paint: Reduce unnecessary memory reallocation/mutable getter#42328
yezhizhen merged 5 commits intoservo:mainfrom
yezhizhen:remove-mut

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Feb 4, 2026 •
edited
Loading

  • Retain capacity of pending_touch_move_actions with fn remove_pending_touch_move_actions
  • Remove unnecessary mutable getter in fn move_allowed
  • Reduces visibility of functions in touch.rs

Just a refactor.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@yezhizhen
Be functional
43790f5 
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen marked this pull request as draft February 4, 2026 09:29
@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Feb 4, 2026

I will take this chance for some other random optimization..

@yezhizhen
Retain capacity.
f2516e9 
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen changed the title touch: Remove unnecessary mutable getter in fn move_allowed touch: Reduce unnecessary memory reallocation/mutable getter Feb 4, 2026
@yezhizhen yezhizhen requested a review from xiaochengh February 4, 2026 09:35
@yezhizhen yezhizhen marked this pull request as ready for review February 4, 2026 09:35
@mrobinson mrobinson changed the title touch: Reduce unnecessary memory reallocation/mutable getter paint: Reduce unnecessary memory reallocation/mutable getter Feb 4, 2026
mrobinson
mrobinson approved these changes Feb 4, 2026
View reviewed changes
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 4, 2026
@yezhizhen
Reduce visibility.
018578a 
Signed-off-by: Euclid Ye <[email protected]>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@yezhizhen
Missing new line
e3f86fb 
Signed-off-by: Euclid Ye <[email protected]>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@yezhizhen yezhizhen enabled auto-merge February 4, 2026 10:04
@yezhizhen yezhizhen added this pull request to the merge queue Feb 4, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 4, 2026
Merged via the queue into servo:main with commit a900d95 Feb 4, 2026
32 checks passed
@yezhizhen yezhizhen deleted the remove-mut branch February 4, 2026 11:33
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@xiaochengh xiaochengh Awaiting requested review from xiaochengh

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yezhizhen @mrobinson @servo-highfive