layout: get rid of some collect() calls#42327
Merged
mrobinson merged 1 commit intoservo:mainfrom Feb 6, 2026
Merged
Conversation
webbeef
requested review from
Loirooriol,
gterzian and
mrobinson
as code owners
servo-highfive
added
the
S-awaiting-review
Signed-off-by: webbeef <[email protected]>
Contributor
|
I did not study the code in detail but should some of these be par_iter() from rayon or depending on the workload par_iter with_min_length? |
Contributor
Author
Maybe, but that was not my focus here. |
mrobinson
approved these changes
Feb 6, 2026
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
This seems pretty harmless. Without measurement, I'm not sure these kind of micro-optimizations make sense though. Most of the collecting is probably happening in layout itself which runs more often and deals with more nodes than layout queries. I think a good thing for these kind of optimizations in the future is some actual measurement.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling a speedometer run showed significant time spent in some layout function in vector allocations. The main change is to switch the result of
query_box_areas()from a Vec to and iterator.Testing: refactoring with no expected test changes