script: Move more steps of AES algorithms to aes_common module#42323
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Feb 4, 2026
Merged
script: Move more steps of AES algorithms to aes_common module#42323TimvdLippe merged 1 commit intoservo:mainfrom
aes_common module#42323TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
Move some common/similar steps of the import key operations of AES-CTR, AES-CBC, AES-GCM, AES-KW and AES-OCB to the shared module `aes_common`. Some comments are also added to the shared module `aes_common` to explain the small difference in the specification of AES-OCB operations. Testing: Refactoring. Existing tests suffice. Signed-off-by: Kingsley Yung <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 4, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some common/similar steps of the import key operations of AES-CTR, AES-CBC, AES-GCM, AES-KW and AES-OCB to the shared module
aes_common.Some comments are also added to the shared module
aes_commonto explain the small difference in the specification of AES-OCB operations.Testing: Refactoring. Existing tests suffice.