Skip to content

wpt/UT: Disable https_proxy for local tests#42322

Merged
yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen:fix-https-proxy
Feb 4, 2026
Merged

wpt/UT: Disable https_proxy for local tests#42322
yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen:fix-https-proxy

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Feb 4, 2026

This helps buddies from MI5, MI6, NSA etc. to run tests behind proxy.

Testing: Tested locally behind proxy. For some reason, I already set 127.0.0.1 and localhost in no_proxy, but it does not work.
Fixes: #42321

.
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen changed the title fix proxy WPT/UT: Disable https_proxy Feb 4, 2026
@yezhizhen yezhizhen marked this pull request as ready for review February 4, 2026 05:20
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@yezhizhen yezhizhen changed the title WPT/UT: Disable https_proxy WPT/UT: Disable https_proxy for local tests Feb 4, 2026
@yezhizhen yezhizhen requested a review from xiaochengh February 4, 2026 05:47
@yezhizhen yezhizhen changed the title WPT/UT: Disable https_proxy for local tests wpt/UT: Disable https_proxy for local tests Feb 4, 2026
Copy link
Copy Markdown
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd perhaps reword the PR description though. Someone might not get that it's a joke, and be confused...

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 4, 2026
@Narfinger
Copy link
Copy Markdown
Contributor

Can you describe the bug a bit more? Shouldn't $no_proxy do the correct thing?

@yezhizhen
Copy link
Copy Markdown
Member Author

Can you describe the bug a bit more? Shouldn't $no_proxy do the correct thing?

I mentioned in #42321 that no_proxy does not work somehow. But thanks.

@yezhizhen yezhizhen added this pull request to the merge queue Feb 4, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 4, 2026
Merged via the queue into servo:main with commit 1eb5e96 Feb 4, 2026
37 checks passed
@yezhizhen yezhizhen deleted the fix-https-proxy branch February 4, 2026 09:38
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 4, 2026
@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Feb 4, 2026

I'd perhaps reword the PR description though. Someone might not get that it's a joke, and be confused...

I promise I won't do this again :D But a joke may actually be the reality..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https_proxy breaks the UT and WPT tests running in local

4 participants