webdriver: Improve input event synchronization time-complexity from O(N²) to O(N)#42309
Merged
jdm merged 3 commits intoservo:mainfrom Feb 3, 2026
Merged
webdriver: Improve input event synchronization time-complexity from O(N²) to O(N)#42309jdm merged 3 commits intoservo:mainfrom
jdm merged 3 commits intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
changed the title
yezhizhen
changed the title
jdm
approved these changes
Feb 3, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
…(N²) to O(N) (#42309) - Rename `wait_for_user_agent_handling_complete` to `wait_for_input_event_handled` - Reduce the time-complexity from $O(N^2)$ to $O(N)$: we are waiting for all `pending_input_event_receivers` anyway. There is no need for `crossbeam_channel::Select` as the sender won't block, and channel is `unbound`. - Add a TODO: Some DOM events may not have been produced at the end of wait. Testing: This is refactor. https://github.com/servo/servo/actions/runs/21627646437 --------- Signed-off-by: Euclid Ye <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait_for_user_agent_handling_completetowait_for_input_event_handledpending_input_event_receiversanyway. There is no need forcrossbeam_channel::Selectas the sender won't block, and channel isunbound.Testing: This is refactor. https://github.com/servo/servo/actions/runs/21627646437