Merged
Conversation
servo-highfive
added
the
S-awaiting-review
servo-highfive
removed
the
S-awaiting-review
eerii
reviewed
Feb 3, 2026
Signed-off-by: atbrakhi <[email protected]>
atbrakhi
force-pushed
the
refactor_debuggerjs
branch
from
a352f45 to
07890ed
Compare
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 3, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Approving on behalf of @eerii
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugger.js had many repetitive code, this change creates 2 helper functions and renames some functions/variables to make it more clear.
Testing: This should not change any functionality