script: Start using &mut JSContext and wrappers2 functions inside module script code#42294
Merged
sagudev merged 4 commits intoservo:mainfrom Feb 4, 2026
Merged
script: Start using &mut JSContext and wrappers2 functions inside module script code#42294sagudev merged 4 commits intoservo:mainfrom
&mut JSContext and wrappers2 functions inside module script code#42294sagudev merged 4 commits intoservo:mainfrom
Conversation
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
the
S-awaiting-review
Contributor
Author
Signed-off-by: Gae24 <[email protected]>
Gae24
force-pushed
the
module-wrappers2
branch
from
f226742 to
d273a3c
Compare
Contributor
Author
|
I haven't touched code around |
Member
It would be nice but we can leave this for follow up. |
sagudev
requested changes
Feb 3, 2026
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
Thank you for doing this work. I have some comments but only last two are blocking as others can be left for follow up.
servo-highfive
added
S-needs-code-changes
Gae24
commented
Feb 3, 2026
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
S-awaiting-review
sagudev
approved these changes
Feb 4, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start using
&mut JSContextand wrappers2 functions for module script code.Testing: A successful build should be enough