script: Support different colorspaces for `<input type=color>` by simonwuelker · Pull Request #42279 · servo/servo

simonwuelker · 2026-02-01T22:27:30Z

This change adds support for the colorspace attribute on color inputs and implements serialization of the input value accordingly.

The color picker from servoshell doesn't yet support non-rgb colorspaces (and neither does the embedding API), so we convert to and from rgb when communicating with the embedder.

Testing: New tests start to pass

Signed-off-by: Simon Wülker <[email protected]>

simonwuelker · 2026-02-01T22:28:48Z

tests/wpt/meta/html/semantics/forms/the-input-element/color.window.js.ini

@@ -8,15 +8,9 @@
  [Testing the empty string with color space 'limited-srgb' and with alpha (value)]


Every test scenario here is executed twice, once with input.setAttribute("value", "foo") and once with "input.value = "foo". We only pass the the setAttribute ones for some reason, I'll investigate this more in a followup.

github-actions · 2026-02-01T22:30:11Z

🔨 Triggering try run (#21571458853) for Linux (WPT)

github-actions · 2026-02-01T22:58:46Z

Test results for linux-wpt from try job (#21571458853):

Flaky unexpected result (38)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /_mozilla/mozilla/getBoundingClientRect.html (#39668)
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
TIMEOUT [expected ERROR] /_webgl/conformance/extensions/oes-texture-half-float-with-canvas.html
CRASH [expected OK] /_webgl/conformance/textures/image/tex-2d-alpha-alpha-unsigned_byte.html

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 18 more unexpected results...

CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
CRASH [expected PASS] /css/css-overflow/scroll-marker-in-display-none-column-crash.html
OK /css/cssom-view/offsetTopLeft-border-box.html (#40826)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
CRASH [expected OK] /html/browsers/browsing-the-web/history-traversal/pagereveal/order-in-new-document-navigation.html
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy.https.sub.html (#41404)
- PASS [expected TIMEOUT] subtest: Feature-Policy header: autoplay * allows the top-level document.
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
- PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- TIMEOUT [expected FAIL] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
Test timed out
```
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- FAIL [expected PASS] subtest: Video should seek to time specified in media fragment syntax
```
assert_equals: expected 3 but got 0
```
TIMEOUT /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- PASS [expected TIMEOUT] subtest: Speed-ups should not change the pitch when preservesPitch=true
- TIMEOUT [expected NOTRUN] subtest: Slow-downs should not change the pitch when preservesPitch=true
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.

OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)

FAIL [expected PASS] subtest: multipart/form-data: Basic File test (normal form)

assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"; filename=\"file-test.txt\"\r\nContent-Type: text/plain\r\n\r\n\r\n--\r\n" but got ""

OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
- PASS [expected FAIL] subtest: text/plain: \r\n in filename (normal form)
OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
CRASH [expected ERROR] /html/webappapis/the-shadowrealmglobalscope-interface/self.any.shadowrealm-in-window.html
FAIL [expected PASS] /png/apng/fcTL-blend-source-solid.html (#41560)
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /webdriver/tests/classic/add_cookie/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_send_keys/events.py
- FAIL [expected PASS] subtest: test_file_upload
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_send_keys/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_async_script/node.py
- FAIL [expected PASS] subtest: test_detached_shadow_root[top_context]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/find_elements/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/get_element_css_value/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
CRASH [expected OK] /webxr/xrSession_sameObject.https.html
CRASH [expected OK] /workers/WorkerGlobalScope_importScripts.htm

Stable unexpected results that are known to be intermittent (27)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/transaction-deactivation-timing.any.worker.html (#38808)
- PASS [expected FAIL] subtest: New transactions are deactivated before next task
- PASS [expected FAIL] subtest: New transactions from microtask are deactivated before next task
OK /_mozilla/css/offset_properties_inline.html (#40543)
- PASS [expected FAIL] subtest: offsetTop
- PASS [expected FAIL] subtest: offsetLeft
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-rounded (drawing text in a canvas)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-user
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
TIMEOUT /fetch/metadata/generated/css-images.https.sub.tentative.html (#42229)
- PASS [expected FAIL] subtest: content sec-fetch-site - Same-Origin -> Same Origin
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- PASS [expected FAIL] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
OK /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
```
assert_equals: expected 22.310000000000002 but got 22.3
```
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- TIMEOUT [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.

Stable unexpected results (2)

OK /html/dom/idlharness.https.html?include=HTML.+
- PASS [expected FAIL] subtest: HTMLInputElement interface: attribute colorSpace
- PASS [expected FAIL] subtest: HTMLInputElement interface: document.createElement("input") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("text") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("hidden") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("search") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("tel") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("url") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("email") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("password") must inherit property "colorSpace" with the proper type
- PASS [expected FAIL] subtest: HTMLInputElement interface: createInput("date") must inherit property "colorSpace" with the proper type
- And 14 more unexpected results...
OK /html/semantics/forms/the-input-element/color-attributes.window.html
- PASS [expected FAIL] subtest: <input type=color>: colorspace attribute

github-actions · 2026-02-01T22:58:53Z

⚠️ Try run (#21571458853) failed!

Signed-off-by: Simon Wülker <[email protected]>

script: Support different colorspaces on <input type=color>

b21eef3

Signed-off-by: Simon Wülker <[email protected]>

simonwuelker requested a review from gterzian as a code owner February 1, 2026 22:27

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

simonwuelker commented Feb 1, 2026

View reviewed changes

simonwuelker added the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

simonwuelker force-pushed the input-colorspaces branch from 650961b to d4c43e7 Compare February 1, 2026 22:33

Update WPT expectations

5de8ab4

Signed-off-by: Simon Wülker <[email protected]>

simonwuelker force-pushed the input-colorspaces branch from 2f8ed28 to 44bfcc1 Compare February 1, 2026 23:05

script: Make other color spaces work with the color picker

813fc02

Signed-off-by: Simon Wülker <[email protected]>

simonwuelker force-pushed the input-colorspaces branch from 44bfcc1 to 813fc02 Compare February 1, 2026 23:25

TimvdLippe approved these changes Feb 2, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 2, 2026

TimvdLippe added this pull request to the merge queue Feb 2, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2026

Merged via the queue into servo:main with commit 83bf475 Feb 2, 2026
30 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Support different colorspaces for `<input type=color>`#42279

script: Support different colorspaces for `<input type=color>`#42279
TimvdLippe merged 3 commits intoservo:mainfrom
simonwuelker:input-colorspaces

simonwuelker commented Feb 1, 2026 •

edited

Loading

Uh oh!

simonwuelker Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -8,15 +8,9 @@
		[Testing the empty string with color space 'limited-srgb' and with alpha (value)]

Uh oh!

Conversation

simonwuelker commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonwuelker Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

simonwuelker commented Feb 1, 2026 •

edited

Loading