Skip to content

script: Add navigator.pdfViewerEnabled#42277

Merged
jdm merged 2 commits intoservo:mainfrom
simonwuelker:pdfViewer
Feb 1, 2026
Merged

script: Add navigator.pdfViewerEnabled#42277
jdm merged 2 commits intoservo:mainfrom
simonwuelker:pdfViewer

Conversation

@simonwuelker
Copy link
Copy Markdown
Contributor

Servo doesn't have a pdf viewer, so we simply set the property to false.

Testing: New tests start to pass

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026
@TimvdLippe TimvdLippe enabled auto-merge February 1, 2026 19:33
@TimvdLippe TimvdLippe added this pull request to the merge queue Feb 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 1, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 1, 2026
Servo doesn't have a pdf viewer, so we simply set the property to
`false`.

Testing: New tests start to pass

---------

Signed-off-by: Simon Wülker <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 1, 2026
@jdm jdm added this pull request to the merge queue Feb 1, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 1, 2026
@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 1, 2026

I had no idea this was a thing!

Merged via the queue into servo:main with commit f822959 Feb 1, 2026
38 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 1, 2026
@Narfinger
Copy link
Copy Markdown
Contributor

@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 2, 2026

Would it make sense to integrate pdf.js? https://mozilla.github.io/pdf.js/

See #38812 and #6098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants