script: Set host for template content by TimvdLippe · Pull Request #42276 · servo/servo

TimvdLippe · 2026-02-01T19:26:54Z

A template element should set the host of a DocumentFragment. However, it didn't have a host yet. That's because ShadowRoot declares a host attribute which returns Element, but its property is declared on DocumentFragment.

Therefore, define the host on DocumentFragment instead and use it in all relevant points for shadow roots. Then, update the pre-insert validity check to use the correct host-including variant of inclusive ancestors. Lastly, set the host of the template to wire it all up.

A template element should set the host of a DocumentFragment. However, it didn't have a host yet. That's because ShadowRoot declares a host attribute which returns Element, but its property is declared on DocumentFragment. Therefore, define the host on DocumentFragment instead and use it in all relevant points for shadow roots. Then, update the pre-insert validity check to use the correct host-including variant of inclusive ancestors. Lastly, set the host of the template to wire it all up. Signed-off-by: Tim van der Lippe <[email protected]>

github-actions · 2026-02-01T19:27:09Z

🔨 Triggering try run (#21568827231) for Linux (WPT)

TimvdLippe · 2026-02-01T19:27:30Z

...mantics/scripting-1/the-template-element/template-element/template-content-hierarcy.html.ini

-  [Template content should throw when its ancestor is being appended.]
-    expected: FAIL
-
  [Template content should throw exception when its ancestor in a different document but connected via host is being append.]


This test fails in all browser: https://wpt.fyi/results/html/semantics/scripting-1/the-template-element/template-element/template-content-hierarcy.html?label=experimental&label=master&aligned

Actually, the assertion is wrong. Sending a fix which passes in Chrome and Firefox.

servo-wpt-sync · 2026-02-01T19:34:39Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57472) with upstreamable changes.

Now it passes in all browsers. It was asserting on the wrong document after being adopted. Signed-off-by: Tim van der Lippe <[email protected]>

servo-wpt-sync · 2026-02-01T19:55:00Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57472).

github-actions · 2026-02-01T19:57:09Z

Test results for linux-wpt from try job (#21568827231):

Flaky unexpected result (33)

OK /FileAPI/file/send-file-form-utf-8.html

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-.txt (x-user-defined) in UTF-8 form

assert_greater_than: file-for-upload-in-form-.txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-â˜ºðŸ˜‚.txt (windows-1252) in UTF-8 form

assert_greater_than: file-for-upload-in-form-â˜ºðŸ˜‚.txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
PASS [expected FAIL] /_mozilla/css/linear_gradients_reverse_a.html
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```

OK /css/CSS2/linebox/vertical-align-top-bottom-001.html (#41015)

FAIL [expected PASS] subtest: text-top+

assert_approx_equals: expected "44" +/- 0 but got 41

FAIL [expected PASS] subtest: text-top+top

assert_approx_equals: expected "5" +/- 0 but got 3

FAIL [expected PASS] subtest: text-top+text-top

assert_approx_equals: expected "5" +/- 0 but got 3

FAIL [expected PASS] subtest: text-top+text-bottom

assert_approx_equals: expected "40" +/- 0 but got 37

FAIL [expected PASS] subtest: text-bottom+

assert_approx_equals: expected "44" +/- 0 but got 45

FAIL [expected PASS] subtest: text-bottom+top

assert_approx_equals: expected "5" +/- 0 but got 7

FAIL [expected PASS] subtest: text-bottom+text-top

assert_approx_equals: expected "5" +/- 0 but got 7

FAIL [expected PASS] subtest: bottom+

assert_approx_equals: expected "49" +/- 0 but got 48

FAIL [expected PASS] subtest: bottom+text-top

assert_approx_equals: expected "45" +/- 0 but got 43

FAIL [expected PASS] subtest: bottom+text-bottom

assert_approx_equals: expected "45" +/- 0 but got 44

FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-rounded (drawing text in a canvas)
CRASH [expected PASS] /css/css-overflow/scroll-marker-in-display-none-column-crash.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Single value - Non-empty name exists
- PASS [expected FAIL] subtest: Newline normalization - \r\n in value (urlencoded)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
CRASH [expected OK] /html/browsers/browsing-the-web/back-forward-cache/service-worker-controlled-after-restore.https.html
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
CRASH [expected OK] /html/browsers/origin/api/origin-from-global.any.worker.html
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic File test (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: text/plain: single quote in name (normal form)
- PASS [expected FAIL] subtest: text/plain: backslash in name (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (formdata event)
OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
ERROR [expected TIMEOUT] /performance-timeline/not-restored-reasons/abort-block-bfcache.window.html
OK /preload/link-header-preload-delay-onload.html (#39622)
- FAIL [expected PASS] subtest: Makes sure that Link headers preload resources and block window.onload after resource discovery
```
assert_true: expected true got false
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
OK /webdriver/tests/classic/element_click/navigate.py
- FAIL [expected PASS] subtest: test_numbers_link
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_send_keys/form_controls.py
- FAIL [expected PASS] subtest: test_input
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_async_script/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
CRASH [expected OK] /webxr/xrSession_sameObject.https.html

Stable unexpected results that are known to be intermittent (29)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /_mozilla/css/offset_properties_inline.html (#40543)
- PASS [expected FAIL] subtest: offsetTop
- PASS [expected FAIL] subtest: offsetLeft
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul)
OK /css/cssom-view/offsetTopLeft-border-box.html (#40826)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy.https.sub.html (#41404)
- TIMEOUT [expected PASS] subtest: Feature-Policy header: autoplay * allows same-origin iframes.
```
Test timed out
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- TIMEOUT [expected FAIL] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
Test timed out
```
TIMEOUT [expected ERROR] /html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html (#40347)
OK /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
```
assert_equals: expected 2.6599999999999966 but got 2.66
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 6.900000000000002 but got 6.9
```
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.

github-actions · 2026-02-01T19:57:18Z

✨ Try run (#21568827231) succeeded.

TimvdLippe requested a review from gterzian as a code owner February 1, 2026 19:26

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

TimvdLippe commented Feb 1, 2026

View reviewed changes

servo-wpt-sync mentioned this pull request Feb 1, 2026

script: Set host for template content web-platform-tests/wpt#57472

Merged

wpt: Fix test

f1ee388

Now it passes in all browsers. It was asserting on the wrong document after being adopted. Signed-off-by: Tim van der Lippe <[email protected]>

TimvdLippe force-pushed the set-template-content-host branch from b044544 to f1ee388 Compare February 1, 2026 19:51

mrobinson approved these changes Feb 2, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 2, 2026

TimvdLippe added this pull request to the merge queue Feb 2, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2026

Merged via the queue into servo:main with commit e8aa7d5 Feb 2, 2026
30 checks passed

TimvdLippe deleted the set-template-content-host branch February 2, 2026 09:09

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Set host for template content#42276

script: Set host for template content#42276
TimvdLippe merged 2 commits intoservo:mainfrom
TimvdLippe:set-template-content-host

TimvdLippe commented Feb 1, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

TimvdLippe Feb 1, 2026

Uh oh!

TimvdLippe Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

TimvdLippe commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

TimvdLippe Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

TimvdLippe Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TimvdLippe commented Feb 1, 2026 •

edited

Loading